Override templates by php version#16
Conversation
I guess this isn't true? i.e. Phpactor depends on this package, this package doesn't depend on Phpactor. |
| class TemplatePathsResolver | ||
| { | ||
| /** | ||
| * @var string In the form of "major.minor.release[extra]" |
There was a problem hiding this comment.
Is this a valid docblock? Otherwise I'd be happy to ommit the @var
There was a problem hiding this comment.
There was a problem hiding this comment.
The @var tag MUST contain the name of the element it documents. An exception to this is when property declarations only refer to a single property. In this case the name of the property MAY be omitted.
Only can be omitted for properties at the moment.
Yes, it's the other way around, I updated it and the message in the PR on phpactor. |
|
I made a PR on this PR which renames the resolver and adds an integration test: camilledejoye#1 |
|
Nice ! |
|
Looks like my change caused the CS to fail.. |
|
Yeah I really need to had some git hook before pushing... |
|
🎉 |
2 participants
Fixes phpactor/phpactor#856
phpactor/phpactor#857 need this PR to be merged in order for the CI to pass.