Skip to content

[Swoole] Sub-request does not receive parent request headers #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DmitriiKoziuk wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Swoole] Sub-request does not receive parent request headers #140

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8609f14
Sub request gets parent request headers
DmitriiKoziuk Aug 8, 2023
659f26c
Improvements after learning how fpm and symfony work with headers
DmitriiKoziuk Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Sub request gets parent request headers
  • Loading branch information
@DmitriiKoziuk
DmitriiKoziuk committed Aug 8, 2023
commit 8609f14ac5ae0c67fa284421c57b3468ad59b83d
34 changes: 29 additions & 5 deletions src/swoole/src/SymfonyHttpBridge.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,15 @@ final class SymfonyHttpBridge
{
public static function convertSwooleRequest(Request $request): SymfonyRequest
{
$sfRequest = new SymfonyRequest(
return new SymfonyRequest(
$request->get ?? [],
$request->post ?? [],
[],
$request->cookie ?? [],
$request->files ?? [],
array_change_key_case($request->server ?? [], CASE_UPPER),
self::buildServer($request),
$request->rawContent()
);
$sfRequest->headers = new HeaderBag($request->header ?? []);

return $sfRequest;
}

public static function reflectSymfonyResponse(SymfonyResponse $sfResponse, Response $response): void
Expand Down Expand Up @@ -62,4 +59,31 @@ public static function reflectSymfonyResponse(SymfonyResponse $sfResponse, Respo
$response->end($sfResponse->getContent());
}
}

/**
* We must add the headers to the server otherwise they will not be available in sub-requests
*/
private static function buildServer(Request $request): array
{
$serverHeaders = [];
if (true === is_array($request->header)) {
foreach ($request->header as $name => $value) {
$name = strtoupper($name);

if (
false === in_array($name, ['CONTENT_TYPE', 'CONTENT_LENGTH', 'CONTENT_MD5'])
&& false === str_starts_with($name, 'HTTP_')
) {
$name = sprintf('HTTP_%s', $name);
}

$serverHeaders[$name] = $value;
}
}

return array_merge(
array_change_key_case($request->server ?? [], CASE_UPPER),
$serverHeaders
);
}
}
38 changes: 37 additions & 1 deletion src/swoole/tests/Unit/SymfonyHttpBridgeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public function testThatSwooleRequestIsConverted(): void

$sfRequest = SymfonyHttpBridge::convertSwooleRequest($request);

$this->assertSame(['REQUEST_METHOD' => 'post'], $sfRequest->server->all());
$this->assertSame(['REQUEST_METHOD' => 'post', 'HTTP_CONTENT-TYPE' => 'application/json'], $sfRequest->server->all());
$this->assertSame(['content-type' => ['application/json']], $sfRequest->headers->all());
$this->assertSame(['foo' => 'cookie'], $sfRequest->cookies->all());
$this->assertSame(['foo' => 'get'], $sfRequest->query->all());
Expand Down Expand Up @@ -148,4 +148,40 @@ public function testStreamedResponseWillRespondWithOneChunkAtATime(): void

SymfonyHttpBridge::reflectSymfonyResponse($sfResponse, $response);
}

public function testThatSubRequestGetsParentRequestHeaders(): void
{
$request = $this->createMock(Request::class);
$request->server = ['request_method' => 'post'];
$request->header = ['host' => 'example.com', 'content-type' => 'application/json'];
$request->cookie = ['foo' => 'cookie'];
$request->get = ['foo' => 'get'];
$request->post = ['foo' => 'post'];
$request->files = [
'foo' => [
'name' => 'file',
'type' => 'image/png',
'tmp_name' => '/tmp/file',
'error' => UPLOAD_ERR_CANT_WRITE,
'size' => 0,
],
];
$request->expects(self::once())->method('rawContent')->willReturn('{"foo": "body"}');

$sfRequest = SymfonyHttpBridge::convertSwooleRequest($request);

$this->assertSame(['host' => ['example.com'], 'content-type' => ['application/json']], $sfRequest->headers->all());

$sfSubRequest = SymfonyRequest::create(
'/some-url',
'get',
[],
$sfRequest->cookies->all(),
[],
$sfRequest->server->all()
);

$this->assertSame('example.com', $sfSubRequest->headers->get('host'));
$this->assertSame('application/json', $sfSubRequest->headers->get('content-type'));
}
}