Skip to content

Optimize browscap.ini loading and get_browser() #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nikic wants to merge 10 commits into from
Closed

Optimize browscap.ini loading and get_browser() #2242

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8043451
Add get_browser() test against larger corpus
nikic Jan 1, 2017
8fa1aaa
Optimize browscap loading and representation
nikic Dec 15, 2016
afa69be
Use different key-value representation in browscap
nikic Dec 15, 2016
7e74cc3
Optimize get_browser() using prefix check
nikic Dec 15, 2016
07600b4
More browscap code cleanup and optimization
nikic Dec 15, 2016
9b91d6d
Add an additional "contains" optimization for browscap
nikic Dec 15, 2016
646453b
Implement additional contains checks
nikic Dec 16, 2016
c5d7286
Refactor contains handling a bit
nikic Dec 17, 2016
aa78d5f
Increase number of contains segments
nikic Dec 17, 2016
d5fc22f
Lowercase only after checking the prefix
nikic Dec 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add get_browser() test against larger corpus 
Testing corpus provided by Anatol against current browscap.ini lite.

About 30% of all agents are not recognized by this browscap.ini,
but this should give us decent coverage.
  • Loading branch information
@nikic
nikic committed Jan 1, 2017
commit 80434518c315c045cdc06f6d991c660d4c8bfe05
Loading