Merged
Conversation
Member
|
It would be nice for that image to use a newer OS (e.g. buster -> bookworm), but I'm not sure if it's possible. The thing with dropping PHP 7.2 tests is that, I imagine, we could no longer guarantee that phan works in PHP 7.2. OTOH, maybe we could drop support for PHP 7.2 entirely, or possibly for PHP 7 in general. That would require a new major version though (v6). |
Collaborator
Author
Seems like Is it a good idea to try using |
Member
Right. I guess it makes sense, since PHP 7.2 is quite old.
Yeah, that's even older...
I quickly tried it and it doesn't seem to work out of the box. I'm sure this can be worked around, but TBH I'd consider dropping support for PHP 7 in a new v6 branch. |
Collaborator
Author
|
I guess when there will be actual code changes incompatible with PHP 7.2, it will have to be dropped indeed. But right now we can get PHP 7.2 checks back green by switching to The last step would be to fix the root cause of failed 8.1 check. @Daimona @rlerdorf are there any other potential side effects from switching to alpine in docker image that is used to run the checks? Otherwise, are we good to merge this once 8.1 is fixed? |
Collaborator
Author
Member
|
Yep, I think this is fine for now. Thank you! |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apt-get updatefails for 7.2 with:Additional context
Initial version of this PR was simply disabling PHP 7.2 checks. Current version of this PR switches from
buster(that is unavailable anymore for 7.2) toalpine(for 7.2, while all other checks keep usingbuster).