Conversation
Contributor
Author
|
Found when trying to make use of the generics improvements in a real project (MediaWiki). I hope I didn't cause too many other bugs :) |
…plate types We resolved the template type in $property_union_type, but not in $property itself, and $property was later passed to sub-methods that do further analysis.
MatmaRex
force-pushed
the
template-property-assign
branch
from
fb1407c to
d012062
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We resolved the template type in $property_union_type, but not in $property itself, and $property was later passed to sub-methods that do further analysis.