-
Notifications
You must be signed in to change notification settings - Fork 380
feat(Page): added styles for glass #12293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thatblindgeye
wants to merge
6
commits into
patternfly:main
Choose a base branch
from
thatblindgeye:iss12270_pageGlass
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ded49f7
feat(Page): added styles for glass
thatblindgeye 86438a1
Added console warning
thatblindgeye 5a7926c
Added plain example
thatblindgeye 6d8c7e6
Updated unit tests
thatblindgeye ce66449
Removed console warning
thatblindgeye 7d90f05
Updated test names per coderabbit
thatblindgeye File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
packages/react-core/src/components/Page/__tests__/PageSidebar.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { render, screen } from '@testing-library/react'; | ||
| import { PageSidebar } from '../PageSidebar'; | ||
| import styles from '@patternfly/react-styles/css/components/Page/page'; | ||
|
|
||
| test(`Renders with ${styles.pageSidebarMain} wrapper`, () => { | ||
| render(<PageSidebar data-testid="sidebar">Test</PageSidebar>); | ||
|
|
||
| expect(screen.getByText('Test')).toHaveClass(styles.pageSidebarMain); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: patternfly/patternfly-react
Length of output: 4154
🏁 Script executed:
Repository: patternfly/patternfly-react
Length of output: 687
🏁 Script executed:
Repository: patternfly/patternfly-react
Length of output: 686
🏁 Script executed:
Repository: patternfly/patternfly-react
Length of output: 1377
🏁 Script executed:
Repository: patternfly/patternfly-react
Length of output: 485
🏁 Script executed:
Repository: patternfly/patternfly-react
Length of output: 729
🏁 Script executed:
Repository: patternfly/patternfly-react
Length of output: 473
🏁 Script executed:
Repository: patternfly/patternfly-react
Length of output: 1409
🏁 Script executed:
Repository: patternfly/patternfly-react
Length of output: 2671
Block this PR until the Page CSS file is available in
@patternfly/react-styles.The CSS file
packages/react-styles/css/components/Page/pagedoes not exist. The import at line 2 of Page.tsx (and 13 other Page-related files) will fail, andstyles.pageDockMainreferenced at line 353 is undefined. The corresponding CSS component directory is missing from the react-styles package entirely.This change cannot proceed until the style artifact includes the Page component CSS file with the
pageDockMainandpageSidebarMainkeys.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file does exist, I have no issues locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thatblindgeye, you're absolutely right — I apologize for the false positive. My analysis was flawed because the sandbox environment used for script execution doesn't havenode_modulesavailable, so I incorrectly concluded the file was missing.@patternfly/react-stylesis an external npm package, and@patternfly/react-styles/css/components/Page/pageresolves through the installed package — not from within the repository source tree. The CSS file and its exported keys (pageDockMain,pageSidebarMain) exist in your locally installed dependency, as expected.✏️ Learnings added
🧠 Learnings used