fix(DrawerPanelContent): add inert when drawer is closed#12027
fix(DrawerPanelContent): add inert when drawer is closed#12027thatblindgeye merged 1 commit intopatternfly:mainfrom
Conversation
logonoff
force-pushed
the
11938-drawerpanelcontent
branch
from
ec1b119 to
7354e16
Compare
|
It looks like the drawerresize.spec.ts integration test is failing - would you mind taking a look? |
logonoff
force-pushed
the
11938-drawerpanelcontent
branch
from
7354e16 to
29aa1e5
Compare
logonoff
changed the title
logonoff
changed the title
|
Preview: https://pf-react-pr-12027.surge.sh A11y report: https://pf-react-pr-12027-a11y.surge.sh |
|
@mcoker, I've updated the PR to just add the It's unclear to me whether this will fix the issue I was having in OCP without running the end to end tests in an updated version of PatternFly. However, as you mentioned, we should have this attribute anyway so I think it's worth adding. We can close the linked issue upon merging, and I'll reopen the issue if the problem continues to happen. |
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
LGTM testing the examples/demos!
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Could we try adding a couple tests, one to check that inert is applied when isExpanded from the DrawerContext is false, and one to check that inert isn't applied when the isExpanded context is true?
logonoff
force-pushed
the
11938-drawerpanelcontent
branch
from
29aa1e5 to
4113ad9
Compare
6 participants
What: Closes #11938
Have not tested this against OCP but this fixes the core issue where the drawer panel content still takes up width even when closed.
After this PR, the panel content is still "display"ed but now takes up width 0.
We cannot use
display: nonehere as that breaks the drawer opening animationAdditional issues: