Skip to content

fix: change no-plain to no-plain-on-glass#8249

Merged
mcoker merged 4 commits intopatternfly:mainfrom
mcoker:issue-8239
Mar 25, 2026
Merged

fix: change no-plain to no-plain-on-glass#8249
mcoker merged 4 commits intopatternfly:mainfrom
mcoker:issue-8239

Conversation

@mcoker
Copy link
Copy Markdown
Contributor

@mcoker mcoker commented Mar 25, 2026 •
edited by coderabbitai bot
Loading

fixes #8239

Summary by CodeRabbit

  • Style

    • Glass-theme plain styling narrowed for Accordion, DataList, Drawer, Page, Table, and Wizard so transparent backgrounds apply more selectively, improving visual consistency.

  • Documentation

    • Component docs updated to introduce and document a new modifier, .pf-m-no-plain-on-glass, that prevents automatic plain styling when the glass theme is enabled.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 25, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: c5a858bd-e4bd-43e0-a25d-9e53fd20bf57

📥 Commits

Reviewing files that changed from the base of the PR and between 89d8fa9 and 2653423.

📒 Files selected for processing (2)
  • src/patternfly/components/Drawer/examples/Drawer.md
  • src/patternfly/components/Page/examples/Page.md
✅ Files skipped from review due to trivial changes (2)
  • src/patternfly/components/Drawer/examples/Drawer.md
  • src/patternfly/components/Page/examples/Page.md

Walkthrough

Renamed .pf-m-no-plain → .pf-m-no-plain-on-glass in multiple component SCSS selectors and updated component documentation so glass-theme plain overrides exclude the new modifier, narrowing when plain-on-glass variable overrides apply.

Changes

Cohort / File(s) Summary
Component SCSS selectors
src/patternfly/components/Accordion/accordion.scss, src/patternfly/components/DataList/data-list.scss, src/patternfly/components/Drawer/drawer.scss, src/patternfly/components/Page/page.scss, src/patternfly/components/Table/table.scss, src/patternfly/components/Wizard/wizard.scss		 Replaced :not(.pf-m-no-plain) with :not(.pf-m-no-plain-on-glass) in glass-theme @at-root/override selectors so the new .pf-m-no-plain-on-glass opt-out controls when plain styling is applied under .pf-v6-theme-glass.
Component documentation
src/patternfly/components/Accordion/examples/Accordion.md, src/patternfly/components/DataList/examples/DataList.md, src/patternfly/components/Drawer/examples/Drawer.md, src/patternfly/components/Page/examples/Page.md, src/patternfly/components/Table/examples/Table.md, src/patternfly/components/Wizard/examples/Wizard.md		 Added/renamed docs to introduce .pf-m-no-plain-on-glass and (where applicable) added .pf-m-plain entries for relevant subcomponents to document plain-on-glass opt-out and explicit plain modifiers.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

Possibly related PRs

Suggested reviewers

  • andrew-ronaldson
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title follows conventional commit format with a 'fix:' prefix and clearly describes the main change of renaming the modifier class from '.pf-m-no-plain' to '.pf-m-no-plain-on-glass' across multiple components.
Linked Issues check ✅ Passed All code changes align with the primary objectives in issue #8239: all six component SCSS files (Accordion, DataList, Drawer, Page, Table, Wizard) have been updated to replace ':not(.pf-m-no-plain)' with ':not(.pf-m-no-plain-on-glass)', and documentation has been updated accordingly.
Out of Scope Changes check ✅ Passed All changes are directly within scope: SCSS selector updates in the six identified components, documentation updates for the new modifier class, and additional documentation entries for previously undocumented plain/no-plain modifiers in affected components.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build
Copy link
Copy Markdown
Collaborator

patternfly-build commented Mar 25, 2026 •
edited
Loading

Preview: https://pf-pr-8249.surge.sh

A11y report: https://pf-pr-8249-a11y.surge.sh

@mcoker
Copy link
Copy Markdown
Contributor Author

mcoker commented Mar 25, 2026

@thatblindgeye do you mind taking another look? Added plain/no-plain docs to components that were missing the docs.

mcoker
mcoker commented Mar 25, 2026
View reviewed changes
mcoker
mcoker commented Mar 25, 2026
View reviewed changes
thatblindgeye
thatblindgeye approved these changes Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcoker did you one better: I took another look and gave another approval

@mcoker mcoker merged commit 429290f into patternfly:main Mar 25, 2026
5 checks passed
@mcoker mcoker deleted the issue-8239 branch March 25, 2026 17:05
@patternfly-build
Copy link
Copy Markdown
Collaborator

patternfly-build commented Mar 25, 2026

🎉 This PR is included in version 6.5.0-prerelease.58 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coderabbitai coderabbitai bot mentioned this pull request Mar 30, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@srambach srambach Awaiting requested review from srambach

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change .pf-m-no-plain modifiers to .pf-m-no-plain-on-glass

3 participants

@mcoker @patternfly-build @thatblindgeye