Skip to content

fix(icons): updated status icons to rh-ui#8179

Merged
mcoker merged 1 commit intopatternfly:mainfrom
thatblindgeye:iss8171_statusUnified
Mar 2, 2026
Merged

fix(icons): updated status icons to rh-ui#8179
mcoker merged 1 commit intopatternfly:mainfrom
thatblindgeye:iss8171_statusUnified

Conversation

@thatblindgeye
Copy link
Copy Markdown
Contributor

@thatblindgeye thatblindgeye commented Feb 26, 2026 •
edited by coderabbitai bot
Loading

Closes #8171

Summary by CodeRabbit

  • Refactor
    • Updated icon rendering across multiple components to use a unified icon system with consistent naming conventions. Icons retain their visual representation and functionality while using an updated rendering approach.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 26, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 744794d and 3958c22.

📒 Files selected for processing (7)
  • src/patternfly/components/Banner/examples/Banner.md
  • src/patternfly/components/Icon/examples/Icon.md
  • src/patternfly/components/ModalBox/modal-box-title-icon.hbs
  • src/patternfly/components/NotificationDrawer/notification-drawer-list-item-header-icon.hbs
  • src/patternfly/components/Popover/popover-title-icon.hbs
  • src/patternfly/components/Popover/popover-title.hbs
  • src/patternfly/components/ProgressStepper/progress-stepper-step-icon.hbs

Walkthrough

This PR migrates status icons across multiple PatternFly components from Font Awesome <i> elements to the unified pfIcon helper, using new rh-ui-* icon names for info, check, warning, error, and notification states.

Changes

Cohort / File(s) Summary
Banner Examples
src/patternfly/components/Banner/examples/Banner.md		 Updated five status icon examples (success, warning, danger, info, custom) from Font Awesome <i> tags to pfIcon helper with corresponding rh-ui-* icon names.
Icon Examples
src/patternfly/components/Icon/examples/Icon.md		 Replaced FontAwesome icons with pfIcon helper in the Status colors example block for all five status states.
ModalBox Alert Icons
src/patternfly/components/ModalBox/modal-box-title-icon.hbs		 Migrated all modal alert icon rendering (custom, info, success, warning, danger, default) from inline Font Awesome markup to pfIcon helper with rh-ui-* icon names.
NotificationDrawer Icons
src/patternfly/components/NotificationDrawer/notification-drawer-list-item-header-icon.hbs		 Converted notification drawer header icons across all states (info, warning, danger, success, custom) from <i> tags to pfIcon helper invocations.
Popover Icons
src/patternfly/components/Popover/popover-title-icon.hbs, src/patternfly/components/Popover/popover-title.hbs		 Replaced hard-coded FontAwesome icon markup with pfIcon helper call and updated icon glyph names to rh-ui-* variants across alert type conditions.
ProgressStepper Icons
src/patternfly/components/ProgressStepper/progress-stepper-step-icon.hbs		 Migrated progress state icons (info, complete, failure, issue) from Font Awesome to pfIcon helper with rh-ui-* icon names.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Possibly related PRs

  • #8147 — Implements the pfIcon helper function that is being used throughout this PR for icon rendering.
  • #8165 — Applies the same icon migration pattern (FontAwesome to pfIcon with rh-ui-* names) across button components.

Suggested reviewers

  • kmcfaul
  • mcoker
  • srambach
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title follows conventional commit guidelines with 'fix' prefix and clearly describes the main change: updating status icons to rh-ui.
Linked Issues check ✅ Passed All required icon mappings from issue #8171 have been implemented across all affected components with correct rh-ui-* icon replacements.
Out of Scope Changes check ✅ Passed All changes are scoped to icon replacements in six components; no extraneous modifications were introduced outside the defined objectives.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build
Copy link
Copy Markdown
Collaborator

patternfly-build commented Feb 26, 2026 •
edited
Loading

Preview: https://pf-pr-8179.surge.sh

A11y report: https://pf-pr-8179-a11y.surge.sh

@thatblindgeye thatblindgeye marked this pull request as ready for review March 2, 2026 15:09
@coderabbitai coderabbitai bot requested review from kmcfaul and srambach March 2, 2026 15:10
mcoker
mcoker approved these changes Mar 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ 🛎️ ⚠️ ‼️

@mcoker
Copy link
Copy Markdown
Contributor

mcoker commented Mar 2, 2026

Going to go ahead and merge just to get the icon swap in. @andrew-ronaldson feel free to review whenever and open an issue with any follow ups.

@mcoker mcoker merged commit 301696e into patternfly:main Mar 2, 2026
5 checks passed
@mcoker mcoker mentioned this pull request Mar 2, 2026
Merged
@coderabbitai coderabbitai bot mentioned this pull request Mar 2, 2026
Merged
@patternfly-build
Copy link
Copy Markdown
Collaborator

patternfly-build commented Mar 2, 2026

🎉 This PR is included in version 6.5.0-prerelease.46 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 2, 2026
Closed
Open
Merged
@thatblindgeye thatblindgeye mentioned this pull request Mar 5, 2026
Closed
This was referenced Mar 13, 2026
Merged
Open
This was referenced Mar 24, 2026
Merged
Closed
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcoker mcoker mcoker approved these changes

@andrew-ronaldson andrew-ronaldson Awaiting requested review from andrew-ronaldson

@kmcfaul kmcfaul Awaiting requested review from kmcfaul

@srambach srambach Awaiting requested review from srambach

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update status icons to rh-icons

3 participants

@thatblindgeye @patternfly-build @mcoker