Actionable comments posted: 3

In `@src/patternfly/base/patternfly-variables.scss`:
- Around line 8-14: Remove the trailing whitespace after the alias on the
existing import (the `@use "./tokens/tokens-redhat" as redhat` line) and add an
import for the missing glass dark tokens file by adding a `@use` for
`tokens-glass-dark` (alias it consistently, e.g., `glass-dark`) next to the
other token imports so the standalone non-redhat glass dark theme is available
alongside `tokens-glass` and `tokens-redhat-glass-dark`.

In `@src/patternfly/base/tokens/tokens-default.scss`:
- Line 115: The token --pf-t--global--text-decoration--offset--hover in
tokens-default.scss is unitless (5) and must be a valid CSS length; change its
value to the same pattern used in tokens-local.scss (for example:
calc(var(--pf-t--global--spacer--xs) + 1px)) so consumers like button.scss
receive a proper length and remain consistent with the default offset token and
normalize.scss usage.

In `@src/patternfly/base/tokens/tokens-redhat-highcontrast-dark.scss`:
- Line 5: Update the misleading header comment "// Only tokens that differ from
base theme (40 tokens)" to reflect the actual number of token definitions
present in src/patternfly/base/tokens/tokens-redhat-highcontrast-dark.scss
(currently 41), or fix the token-generation script so it emits the correct
count; locate the header comment in that SCSS file and either increment the
numeric value to 41 or adjust the generator logic that produces the count so the
comment matches the actual number of token definitions.

this all looks right to me! so easy to see the differences with the shortened list!

I did just add in a new token for global--background--color--floating & added "--primary" to the end of the current glass token ((but i likely added those in after you pulled these))

Everyting LGTM. On the new glass token names, just some feedback. I think we should tweak them before trying to use them. Do we want to do that in this PR or as a follow up?

  --pf-t--global--background--color--glass--floating: rgba(255, 255, 255, 0.8000);
  --pf-t--global--background--color--glass--primary: rgba(255, 255, 255, 0.8000);
  --pf-t--global--background--filter--glass: 12.5;
  --pf-t--global--background--opacity--glass: 80;

Thoughts:

1. Since the background colors have the opacity built in, --pf-t--global--background--opacity--glass won't do anything.
2. --filter--glass: 12.5 - the token is named "filter" but the value is specific to the "blur" filter. This is fine, but to future proof it, I'd separate those concepts somehow so that we could add extra filters (like saturate() or contrast() or opacity()). It would also be great to get this as px in the token (12.5px)
3. --opacity--glass: 80 - token looks good but would be great to get with % (80%).
4. Would it make sense to have a unique opacity and/or blur for floating vs primary?

My suggestion:

1. Make --pf-t--global--background--color--glass--floating and --pf-t--global--background--color--glass--primary "figma only" vars, so we won't import them.
2. We will add --pf-t--global--background--color--glass--floating and --pf-t--global--background--color--glass--primary as local/custom vars, and we'll set the color/opacity in them. So both figma and core will use the same var name for the actual var that gets used as the glass background color value.
3. For both the primary and floating background colors, add a new var in figma that holds just the color. This would be for core only, for us to combine with the opacity var to construct the color function. We can name them --pf-t--global--background--color--glass--floating--base or something (with --base at the end). Not sure if we have an existing naming pattern that would work there? The value can be an existing token, too, instead of an rgb(), if a token is more ideal there.
4. Change --filter--glass to --filter--blur--glass. Then if we add a contrast() filter or something, we can use --filter--contrast--glass. Also add px to the value so it's 12.5px. I thought about using --blur--glass, but if we added an extra opacity filter, using --blur--glass as the filter name would imply we would add --opacity--glass for the opacity filter, but --opacity--glass is already in use, so we would have a name conflict.
5. Add % to --opacity--glass so it's 80%

So the token export would look like

  // from figma
  --pf-t--global--background--color--glass--floating--base: var(--pf-t--color--white);
  --pf-t--global--background--color--glass--primary--base: var(--pf-t--color--white);
  --pf-t--global--background--filter--blur--glass: 12.5px;
  --pf-t--global--background--opacity--glass: 80%;

  // core custom/local styles
  --pf-t--global--background--color--glass--floating: color-mix(in srgb, var(-pf-t--global--background--color--glass--floating--base) var(--pf-t--global--background--opacity--glass), transparent);
  --pf-t--global--background--color--glass--primary: color-mix(in srgb, var(-pf-t--global--background--color--glass--primary--base) var(--pf-t--global--background--opacity--glass), transparent);

On 2 & 3 above, we could also do it like this:

  // from figma - same names as the figma only tokens
  --pf-t--global--background--color--glass--floating: var(--pf-t--color--white);
  --pf-t--global--background--color--glass--primary: var(--pf-t--color--white);

  // core custom/local styles
  --pf-t--global--background--color--glass--floating--default: color-mix(in srgb, var(-pf-t--global--background--color--glass--floating) var(--pf-t--global--background--opacity--glass), transparent);
  --pf-t--global--background--color--glass--primary--default: color-mix(in srgb, var(-pf-t--global--background--color--glass--primary) var(--pf-t--global--background--opacity--glass), transparent);

LGTM! Will follow up on the issues I brought up;.