This repository was archived by the owner on Feb 7, 2023. It is now read-only.
Making source and public folders a setting in config.ini#288
Closed
skepsys wants to merge 9 commits into
Closed
Conversation
…pdates in builder and migrations)
…ecursively. For example, these are now quite possible settings in config.ini for paths: sourceDir = "some/long/path/to/source" publicDir = "../../../path/could/go/even/outside/patterlab/directory" NOTE: paths should be related to PatterLab root folder, where /config, /core and /extras folders are placed.
This is done to show the message just once (when starting watching mode it was shown twice before this fix)
Author
|
Changes were tested with generator, watcher and autoreload features, but only on windows. I wonder if there are any problems with slashes in paths or something like that on mac or linux, that's why some testing on that plarforms will be highly appreciated :) |
Member
|
I'll test this locally later this week. PL2 has this covered but since it's taking me a gajillion years to push it out I'll try to get this merged. |
|
I took this for a spin on my mac and it works beautifully. |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the original patternlab-php (as for release 0.7.12)
/sourceand/publicdirectories were hard-coded in different places (php, json etc). So the difference here is that the source and the output paths were made configurable viaconfig.ini. By default both paths are the same as in the original version, but you can change them by tweakingcore/config/config.ini.defaultbefore starting the generator for the first time.NOTES:
/config,/coreand/extrasfolders are placed)./sourceand/publicfolders were removed from the project rootFor example, these are now quite possible settings in
config.ini.defaultfor paths:sourceDir = "some/long/path/to/source"publicDir = "../../../path/could/go/even/outside/patterlab/directory"P.S. Yes, I noticed that in the original
devbranch some major changes have been done to make these paths configurable, but the last commits were made about a year ago and this work doesn't seemed to be finished. That's why I decided to implement this functionality in a pretty simple way, without huge refactoring of the code. Hope this will allow the community to use PatternLab in a much more flexible way. And of course many thanks to Dave Olsen and all other contributors for this wonderful tool :))