Centralized URL Normalization #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallstop
commented
Nov 17, 2025
| "resolved": "https://registry.npmjs.org/@types/node/-/node-22.13.0.tgz", | ||
| "integrity": "sha512-ClIbNe36lawluuvq3+YYhnIN2CELi+6q8NpnM7PYp4hBn/TatfboPgVSm2rwKRfnV2M+Ty9GWDFI64KEe+kysA==", | ||
| "license": "MIT", | ||
| "peer": true, |
Contributor
Author
There was a problem hiding this comment.
I'll revert all of these, not sure what happened here.
Contributor
Author
There was a problem hiding this comment.
Hmmm I did a a full re-generate of the package-lock.json, happy to do whatever you want with this, I'm not a TS/JS wizard.
Simplification Revert Revert package-lock.json
wallstop
force-pushed
the
feature/url-normalization
branch
from
4763ae0 to
c97114d
Compare
Owner
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is the first of a few PRs that helped stabilize / improve this app in Windows.
This change centralizes the URL normalization, makes it slightly more robust (errors during normalization will cause the URL to be returned), and pipes it through to all places that touch URLs.
Now, if someone is at
https://patreon.com/and manually tries to go tohttps://patreon.com(no trailing slash), nothing should happen.This is important, for me, because page navigation is quite slow and I manually bumble through the URLs trying to get things to work.