-
Notifications
You must be signed in to change notification settings - Fork 51
Remove all pkg_resources usage #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,10 +52,8 @@ | |
| packages=find_packages(exclude=['ez_setup', 'examples', 'packages', 'tests*']), | ||
| package_data=finddata.find_package_data( | ||
| exclude_directories=finddata.standard_exclude_directories + ('tests',)), | ||
| namespace_packages=['paste'], | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not 100% sure if we need some guiding to setuptools to discover the code as we are not using a |
||
| zip_safe=False, | ||
| install_requires=[ | ||
| 'setuptools', # pkg_resources | ||
| ], | ||
| extras_require={ | ||
| 'subprocess': [], | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,5 +3,3 @@ | |
| import os | ||
|
|
||
| sys.path.insert(0, os.path.dirname(os.path.dirname(__file__))) | ||
|
|
||
| import pkg_resources | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the packaging guide this namespace style is also obsolete: https://packaging.python.org/en/latest/guides/packaging-namespace-packages/#legacy-namespace-packages
The broader question here would be: are there other paste python distributions that share the namespace and thus should be migrated together?
As a temporal solution maybe https://pypi.org/project/horse-with-no-namespace/ works to patch the problem, though it mentions
pkg_resourcesstyle namespaces notpkgutilnamespaces