Fix check for existing flutter submodule - #7
Merged
Conversation
In my project I have a submodule named `flutter_custom_tabs`, which breaks the wrapper's check for the existing flutter submodule. This change [references](https://stackoverflow.com/a/10346824/3911006) the fact that the `.flutter` command in grep is using regex, meaning anyone else with submodules that match with the string `flutter` in it will fail silently here.
Owner
|
Thanks, that's a good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my project I have a submodule named
flutter_custom_tabs, which breaks the wrapper's check for the existing flutter submodule. This change references the fact that the.fluttercommand in grep is using regex, meaning anyone else with submodules that match with the stringflutterin it will fail silently here.