feat: require exact project hook review - #201
Merged
Merged
Conversation
added 29 commits
August 1, 2026 13:32
oratis
marked this pull request as ready for review
August 2, 2026 06:44
Owner
Author
Review: approved ✅Directory trust (#197) answers "do I trust this repo's settings". It does not answer "do I trust this repo's hook commands" — and hooks are arbitrary shell that runs automatically around tool calls. Requiring separate, exact-definition hash review for project/local command hooks is the correct additional gate, and it lines up with threat #4 in What I checked
Validation: CI green; full suite green locally at the stack tip. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deepcode hooks list,trust <hash...|--all>, andrevokehook_review_requireddiagnostics without serializing commandsValidation
pnpm format:checkpnpm lint(one pre-existing warning)pnpm typecheckpnpm test(994 passed, 12 skipped)pnpm docs:checkpnpm buildpnpm --filter @deepcode/desktop test:e2e(4 passed)