Lifecycle: distinguish model steps from user turns - #183
Merged
Conversation
added 6 commits
August 1, 2026 13:32
Owner
Author
Review: approved ✅Small (+31/-17) but it fixes a real semantic conflation: there was no way for a client to tell "the model finished one round-trip" from "the user's turn is over". Anything driving UI state off the old signal was guessing. What I checked
This is the event contract the app-server (#188) and every thin client downstream depend on, so landing it as its own reviewable slice ahead of them is the right ordering. Validation: CI green; full suite green locally at the stack tip. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model_step_completeevent for each provider round-tripturn_completeexactly once for eachrunAgentterminal stateValidation
pnpm docs:checkpnpm lint(3 pre-existing warnings, 0 errors)pnpm format:checkpnpm typecheckpnpm testpnpm buildcargo check --manifest-path apps/desktop/src-tauri/Cargo.tomlcargo test --manifest-path apps/desktop/src-tauri/Cargo.toml(31 passed)Stack
Depends on #182, #181, and #180. This is the lifecycle-invariant slice of PR 3; protocol extraction and record/replay remain follow-ups.