Add Volume Attachment id getter #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelmazzuola
commented
Feb 19, 2020
|
|
||
|
|
||
|
|
||
| private static final long serialVersionUID = 1L; |
Member
Author
There was a problem hiding this comment.
spaces or tabs? @olivergondza
some classes use spaces, others tabs
Member
There was a problem hiding this comment.
Yeah, current code style is a mess. Lest just stick with whatever the particular file is using for now (provided it is consistent internally) in order to keep the diffs minimal.
I have no experience with .editorconfig you have suggested, so that is something to have a look at. If not for the sake of consistency, then to get rid of that blasted tabs.
| "id": "8a9287b7-4f4d-4213-8d75-63470f19f27c", | ||
| "volume_id": "8a9287b7-4f4d-4213-8d75-63470f19f27c" | ||
| "volume_id": "8a9287b7-4f4d-4213-8d75-63470f19f27c", | ||
| "attachment_id": "f0dcbc70-52ee-11ea-8d77-2e728ce88125" |
Member
There was a problem hiding this comment.
Pardon my silly question, but have you verified the response format against a living instance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #22