bump image builder by deads2k · Pull Request #20256 · openshift/origin

deads2k · 2018-07-09T13:15:37Z

Looks like levels of deps for imagebuilder don't want to match origin 3.10. I pinned everything, then added this.

As I recall, we only need this for pkg/build/builders which are logically a separate product/binary. We really should split those out to make this work easier, less conflicty, and less dangerous

/assign @smarterclayton @liggitt

liggitt · 2018-07-09T13:20:02Z

/lgtm

openshift-ci-robot · 2018-07-09T13:20:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [deads2k,liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

smarterclayton · 2018-07-09T14:34:58Z

/retest Someone accidentally deleted the service-catalog release-3.10 branch

…

On Mon, Jul 9, 2018 at 9:20 AM, OpenShift CI Robot ***@***.*** > wrote: @deads2k <https://github.com/deads2k>: The following tests *failed*, say /retest to rerun them all: Test name Commit Details Rerun command ci/openshift-jenkins/extended_conformance_install f23b654 <f23b654> link <https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20256/test_pull_request_origin_extended_conformance_install_310/52/> /test extended_conformance_install ci/openshift-jenkins/extended_builds f23b654 <f23b654> link <https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20256/test_pull_request_origin_extended_builds_310/13/> /test extended_builds ci/openshift-jenkins/extended_image_ecosystem f23b654 <f23b654> link <https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20256/test_pull_request_origin_extended_image_ecosystem_310/24/> /test extended_image_ecosystem Full PR test history <https://openshift-gce-devel.appspot.com/pr/20256>. Your PR dashboard <https://openshift-gce-devel.appspot.com/pr/deads2k>. Please help us cut down on flakes by linking to <https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests> an open issue <https://github.com/openshift/origin/issues?q=is:issue+is:open> when you hit one in your PR. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/devel/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#20256 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_pyUomzOL05nt73tjOOr6-WXmIygMks5uE1iqgaJpZM4VHr6k> .

openshift-bot · 2018-07-09T16:12:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-07-09T18:06:56Z

/test cross

openshift-bot · 2018-07-09T18:12:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

smarterclayton · 2018-07-09T19:11:20Z

Travis rules are complaining about your commit name, but only you know whether you care

openshift-bot · 2018-07-09T20:13:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

deads2k · 2018-07-09T22:00:03Z

Travis rules are complaining about your commit name, but only you know whether you care

Not anymore. I'll update the commit checker later. Rules are much simpler now that we don't pick for any repo but kube and we always update all deps.

deads2k · 2018-07-09T22:00:24Z

/test cross

openshift-bot · 2018-07-09T22:13:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-07-10T00:13:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

smarterclayton · 2018-07-10T02:13:56Z

A note, this had nothing to do with imagebuilder deps, which are deliberately chosen to match origin.

openshift-bot · 2018-07-10T02:14:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-07-10T08:14:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

mfojtik · 2018-07-10T08:38:59Z

/retest

openshift-bot · 2018-07-10T10:14:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-07-10T12:16:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

mfojtik · 2018-07-10T13:35:41Z

/refresh

openshift-bot · 2018-07-10T14:17:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-07-10T16:18:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

stevekuznetsov · 2018-07-10T17:07:49Z

@deads2k looks like your commits are bad?

Running hack/verify-upstream-commits.sh:19: executing 'commitchecker' expecting success...
FAILURE after 0.168s: hack/verify-upstream-commits.sh:19: executing 'commitchecker' expecting success: the command returned the wrong error code
There was no output from the command.
Standard error from the command:
The following commits contain Godeps changes but aren't declared as UPSTREAM:
[f23b65448] bump image builder
  - vendor/github.com/openshift/imagebuilder/cmd/imagebuilder/imagebuilder.go
  - vendor/github.com/openshift/imagebuilder/dockerclient/archive.go
  - vendor/github.com/openshift/imagebuilder/dockerclient/archive_test.go
  - vendor/github.com/openshift/imagebuilder/dockerclient/client.go
  - vendor/github.com/openshift/imagebuilder/dockerclient/conformance_test.go
  - vendor/github.com/openshift/imagebuilder/dockerclient/copyinfo_test.go
  - vendor/github.com/openshift/imagebuilder/dockerclient/directory.go
  - vendor/github.com/openshift/imagebuilder/dockerclient/testdata/copy/Dockerfile
  - vendor/github.com/openshift/imagebuilder/dockerclient/testdata/copy/script
  - vendor/github.com/openshift/imagebuilder/dockerclient/testdata/copydir/Dockerfile
  - vendor/github.com/openshift/imagebuilder/dockerclient/testdata/copydir/dir/file
  - vendor/github.com/openshift/imagebuilder/dockerclient/testdata/copyrename/Dockerfile
  - vendor/github.com/openshift/imagebuilder/dockerclient/testdata/copyrename/file1
The following UPSTREAM commits modify files outside Godeps:
[f23b65448] bump image builder
  - glide.lock
  - vendor/github.com/openshift/imagebuilder/cmd/imagebuilder/imagebuilder.go
  - vendor/github.com/openshift/imagebuilder/dockerclient/archive.go
  - vendor/github.com/openshift/imagebuilder/dockerclient/archive_test.go
  - vendor/github.com/openshift/imagebuilder/dockerclient/client.go
  - vendor/github.com/openshift/imagebuilder/dockerclient/conformance_test.go
  - vendor/github.com/openshift/imagebuilder/dockerclient/copyinfo_test.go
  - vendor/github.com/openshift/imagebuilder/dockerclient/directory.go
  - vendor/github.com/openshift/imagebuilder/dockerclient/testdata/copy/Dockerfile
  - vendor/github.com/openshift/imagebuilder/dockerclient/testdata/copy/script
  - vendor/github.com/openshift/imagebuilder/dockerclient/testdata/copydir/Dockerfile
  - vendor/github.com/openshift/imagebuilder/dockerclient/testdata/copydir/dir/file
  - vendor/github.com/openshift/imagebuilder/dockerclient/testdata/copyrename/Dockerfile
  - vendor/github.com/openshift/imagebuilder/dockerclient/testdata/copyrename/file1

deads2k · 2018-07-10T17:38:50Z

@deads2k looks like your commits are bad?

That didn't use to matter. I'll adjust the commit checker

openshift-ci-robot · 2018-07-10T17:52:18Z

New changes are detected. LGTM label has been removed.

deads2k · 2018-07-10T18:35:32Z

/retest

openshift-bot · 2018-07-11T00:21:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-07-11T06:24:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

deads2k · 2018-07-11T12:09:21Z

@bparees can you look and see if the extended image ecosystem job has rotted? It passed, I changed a commit message (no code changes) and it now fails.

deads2k · 2018-07-11T13:28:44Z

/retest

bparees · 2018-07-11T13:38:37Z

it hasn't rotted (it passed the last 2 nightly runs: https://ci.openshift.redhat.com/jenkins/job/test_branch_origin_extended_image_ecosystem/) but there does appear to be a flake w/ some of the replica tests that occasionally hangs the job for the full 6 hours. The common factor in all of them is that they use an NFS pod for PV storage. I will say I don't think we were seeing those hangs before the rebase :)

bparees · 2018-07-11T13:40:14Z

(we've also added logic, at least to the mongo one, to time them out sooner. Looks like your test job hadn't picked up that change though, which is unfortunate since i was hoping to get some more debug info out of things when we handle the timeout ourselves)

deads2k added 2 commits July 9, 2018 08:59

pin all 3.10 deps

997c445

update glide for latest imagebuilder

89458a0

openshift-ci-robot assigned liggitt and smarterclayton Jul 9, 2018

openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 9, 2018

openshift-ci-robot requested review from bparees and stevekuznetsov July 9, 2018 13:15

deads2k mentioned this pull request Jul 9, 2018

bump(*): Pick up latest image builder #20248

Closed

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2018

deads2k added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 10, 2018

bump(*)

609dff3

deads2k force-pushed the rebase-02-imagebuilder-10 branch from f23b654 to 609dff3 Compare July 10, 2018 17:52

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2018

deads2k added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2018

bparees removed their request for review July 11, 2018 01:33

openshift-merge-robot merged commit 114b3b8 into openshift:release-3.10 Jul 11, 2018

Conversation

deads2k commented Jul 9, 2018

Uh oh!

liggitt commented Jul 9, 2018

Uh oh!

openshift-ci-robot commented Jul 9, 2018

Uh oh!

smarterclayton commented Jul 9, 2018 via email

Uh oh!

openshift-bot commented Jul 9, 2018

Uh oh!

openshift-bot commented Jul 9, 2018

Uh oh!

openshift-bot commented Jul 9, 2018

Uh oh!

smarterclayton commented Jul 9, 2018

Uh oh!

openshift-bot commented Jul 9, 2018

Uh oh!

deads2k commented Jul 9, 2018

Uh oh!

deads2k commented Jul 9, 2018

Uh oh!

openshift-bot commented Jul 9, 2018

Uh oh!

openshift-bot commented Jul 10, 2018

Uh oh!

smarterclayton commented Jul 10, 2018

Uh oh!

openshift-bot commented Jul 10, 2018

Uh oh!

openshift-bot commented Jul 10, 2018

Uh oh!

mfojtik commented Jul 10, 2018

Uh oh!

openshift-bot commented Jul 10, 2018

Uh oh!

openshift-bot commented Jul 10, 2018

Uh oh!

mfojtik commented Jul 10, 2018

Uh oh!

openshift-bot commented Jul 10, 2018

Uh oh!

openshift-bot commented Jul 10, 2018

Uh oh!

stevekuznetsov commented Jul 10, 2018

Uh oh!

deads2k commented Jul 10, 2018

Uh oh!

openshift-ci-robot commented Jul 10, 2018

Uh oh!

deads2k commented Jul 10, 2018

Uh oh!

openshift-bot commented Jul 11, 2018

Uh oh!

openshift-bot commented Jul 11, 2018

Uh oh!

deads2k commented Jul 11, 2018

Uh oh!

deads2k commented Jul 11, 2018

Uh oh!

bparees commented Jul 11, 2018

Uh oh!

bparees commented Jul 11, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants