Skip to content

[i18n] Move alert prose from native-libraries partial into an include file#7452

Merged
chalin merged 2 commits intoopen-telemetry:mainfrom
chalin:chalin-im-lib-shortcode-conv-2025-07-31
Aug 1, 2025
Merged

[i18n] Move alert prose from native-libraries partial into an include file#7452
chalin merged 2 commits intoopen-telemetry:mainfrom
chalin:chalin-im-lib-shortcode-conv-2025-07-31

Conversation

@chalin
Copy link
Contributor

@chalin chalin commented Aug 1, 2025

  • Contributes to [i18n] Factor prose out of shortcodes like docs/latest-release #6460
  • Factors out the prose part of the native-libraries partial, putting it into an include file
    • Replaces the inline alert-shortcode HTML by a call to the alert shortcode
  • Adds a func partial used to determine the language that a page is a part of when under docs/languages
  • There was not change to the generated site code as a result of the refactoring. Changes were introduced by using the alert shortcode instead of hard-coded (obsolete) HTML.

Preview

@chalin chalin requested a review from a team as a code owner August 1, 2025 00:03
@chalin chalin added the i18n Internationalization and localization label Aug 1, 2025
@opentelemetrybot opentelemetrybot requested review from a team August 1, 2025 00:03
@chalin chalin changed the title [i18n] Factor alert from native-libraries partial into an include file [i18n] Move alert prose from native-libraries partial into an include file Aug 1, 2025
Copy link
Member

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

@chalin chalin added this pull request to the merge queue Aug 1, 2025
@chalin
Copy link
Contributor Author

chalin commented Aug 1, 2025

The Java page changes are editorial only, dropping a shortcode argument that is no longer needed, so I'll merge now.

Merged via the queue into open-telemetry:main with commit 6eddc72 Aug 1, 2025
19 checks passed
@chalin chalin deleted the chalin-im-lib-shortcode-conv-2025-07-31 branch August 1, 2025 00:20
@github-project-automation github-project-automation bot moved this from Opened to Done in SIG Comms: Docs Translation Aug 1, 2025
jaehanbyun pushed a commit to jaehanbyun/opentelemetry.io that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Internationalization and localization lang:ja lang:pt sig:java

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants