(docs/internal-telemetry): add example for labels#7257
Merged
tiffany76 merged 6 commits intoopen-telemetry:mainfrom Jul 7, 2025
Merged
(docs/internal-telemetry): add example for labels#7257tiffany76 merged 6 commits intoopen-telemetry:mainfrom
tiffany76 merged 6 commits intoopen-telemetry:mainfrom
Conversation
opentelemetrybot
requested review from
a team and
evan-bradley
and removed request for
a team
Member
|
/fix:format |
Contributor
|
✅ |
Member
|
Thank you, @timojohlo! We appreciate your help making the docs better. This PR might be faster to review and merge than #7035, which is making bigger changes. So let's have the @open-telemetry/collector-approvers take a look. Thanks! |
tiffany76
approved these changes
Jul 7, 2025
Member
tiffany76
left a comment
tiffany76
left a comment
There was a problem hiding this comment.
I left a couple copyedit suggestions, but otherwise it LGTM!
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
Contributor
|
Thank you for your contribution @timojohlo! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an example on how to add additional labels to internal metrics generated by the Collector. I stumbled across this problem and could not yet find an example that explained how to do it.
I also saw a major change to this document with #7035. If agreed, this commit could be included there.