Move snapshot publishing to daily build#7886
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7886 +/- ##
=========================================
Coverage 90.08% 90.08%
Complexity 7325 7325
=========================================
Files 825 825
Lines 22051 22051
Branches 2179 2179
=========================================
Hits 19865 19865
Misses 1506 1506
Partials 680 680 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trask
force-pushed
the
snapshot-failure-notification
branch
from
499af8e to
705ffb4
Compare
|
How do we get notified of failures with these nightly jobs (just curious..not familiar with how that works) |
| - link-check | ||
| - publish-snapshots | ||
| if: always() | ||
| uses: ./.github/workflows/reusable-workflow-notification.yml |
There was a problem hiding this comment.
How do we get notified of failures with these nightly jobs (just curious..not familiar with how that works)
@jkwatson this workflow_call will open an issue in the repo if the daily build fails (and it will close the issue if it later passes)
|
Will this publish a snapshot even if there are no changes in a given day? I don't think that's necessarily bad, but I just thought I'd ask to be sure. |
yes it will |
2 participants
I think publishing snapshots only daily is fine. The new daily workflow will trigger issue creation when snapshot publishing fails.
Port of open-telemetry/opentelemetry-java-contrib#2481
FWIW, java contrib repo publishing is working again, though not really convinced it's related to this change 🤷♂️