Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7784 +/- ##
=========================================
Coverage 90.17% 90.18%
- Complexity 7190 7191 +1
=========================================
Files 814 814
Lines 21724 21724
Branches 2129 2129
=========================================
+ Hits 19589 19591 +2
+ Misses 1467 1466 -1
+ Partials 668 667 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trask
commented
Oct 23, 2025
Comment on lines
+91
to
+92
| "-Xlint:-serial", | ||
| "-Xlint:-this-escape", |
jack-berg
reviewed
Oct 24, 2025
| // target. | ||
| java { | ||
| toolchain { | ||
| languageVersion.set(JavaLanguageVersion.of(17)) |
Member
There was a problem hiding this comment.
Is it no longer relevant to set the java language version for the build of buildSrc?
Member
Author
There was a problem hiding this comment.
I don't think so, other repos don't
jack-berg
approved these changes
Oct 24, 2025
the-clam
pushed a commit
to the-clam/opentelemetry-java
that referenced
this pull request
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently built on top of #7780Motivated by #7779