call auto configure listener with declarative config#7654
Merged
jkwatson merged 5 commits intoopen-telemetry:mainfrom Sep 22, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7654 +/- ##
=========================================
Coverage 90.12% 90.12%
- Complexity 7183 7185 +2
=========================================
Files 814 814
Lines 21675 21685 +10
Branches 2123 2123
=========================================
+ Hits 19534 19544 +10
Misses 1475 1475
Partials 666 666 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jkwatson
reviewed
Sep 15, 2025
| maybeRegisterShutdownHook(fromFileConfiguration.getOpenTelemetrySdk()); | ||
| OpenTelemetrySdk openTelemetrySdk = fromFileConfiguration.getOpenTelemetrySdk(); | ||
| maybeRegisterShutdownHook(openTelemetrySdk); | ||
| callAutoConfigureListeners(spiHelper, openTelemetrySdk); |
Contributor
There was a problem hiding this comment.
Can we write a simple test to verify this happens?
Member
Author
There was a problem hiding this comment.
that turned out to be very helpful - it didn't work before...
zeitlinger
force-pushed
the
declarative-config-auto-config-listener
branch
from
c9ff575 to
df5c3c0
Compare
zeitlinger
force-pushed
the
declarative-config-auto-config-listener
branch
from
4af7154 to
620ff48
Compare
jkwatson
approved these changes
Sep 22, 2025
github-project-automation
bot
moved this from Awaiting Review
to Done
in Declarative Configuration: Java
the-clam
pushed a commit
to the-clam/opentelemetry-java
that referenced
this pull request
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.