Skip to content

Switch version from function to string in otelrestful#8360

Merged
dmathieu merged 3 commits intoopen-telemetry:mainfrom
osullivandonal:switch-versions-from-function-to-strings-in-otelrestful
Jan 8, 2026
Merged

Switch version from function to string in otelrestful#8360
dmathieu merged 3 commits intoopen-telemetry:mainfrom
osullivandonal:switch-versions-from-function-to-strings-in-otelrestful

Conversation

@osullivandonal
Copy link
Contributor

Change Version() func to const Version string in otelrestful

Part of #8272

@osullivandonal osullivandonal requested review from a team and dashpole as code owners January 7, 2026 11:59
@dmathieu
Copy link
Member

dmathieu commented Jan 7, 2026

This needs a changelog entry.

@osullivandonal
Copy link
Contributor Author

This needs a changelog entry.

Done!

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.3%. Comparing base (3113656) to head (b440e0f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8360     +/-   ##
=======================================
- Coverage   82.3%   82.3%   -0.1%     
=======================================
  Files        191     190      -1     
  Lines      13775   13773      -2     
=======================================
- Hits       11340   11338      -2     
  Misses      2030    2030             
  Partials     405     405             
Files with missing lines Coverage Δ
...hub.com/emicklei/go-restful/otelrestful/restful.go 100.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu merged commit bdd9e3a into open-telemetry:main Jan 8, 2026
28 checks passed
@MrAlias MrAlias added this to the v1.40.0 milestone Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants