Switch version from function to string in otelmongo#8340
Merged
dmathieu merged 8 commits intoopen-telemetry:mainfrom Jan 14, 2026
Merged
Switch version from function to string in otelmongo#8340dmathieu merged 8 commits intoopen-telemetry:mainfrom
dmathieu merged 8 commits intoopen-telemetry:mainfrom
Conversation
|
|
flc1125
approved these changes
Dec 30, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8340 +/- ##
=======================================
- Coverage 82.3% 82.3% -0.1%
=======================================
Files 181 179 -2
Lines 13699 13695 -4
=======================================
- Hits 11278 11274 -4
Misses 2023 2023
Partials 398 398
🚀 New features to boost your workflow:
|
dmathieu
approved these changes
Jan 5, 2026
pellared
reviewed
Jan 5, 2026
instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/test/version.go
Outdated
Show resolved
Hide resolved
pellared
previously requested changes
Jan 5, 2026
Member
pellared
left a comment
pellared
left a comment
There was a problem hiding this comment.
Internal comments should not be visible in pkg.go.dev.
pellared
reviewed
Jan 5, 2026
instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/version.go
Outdated
Show resolved
Hide resolved
…rsion.go Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
dmathieu
reviewed
Jan 12, 2026
prestonvasquez
approved these changes
Jan 13, 2026
Member
|
@lcorinna Please fix the conflict in the |
dmathieu
dismissed
pellared’s stale review
The requested changed have been applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(otelmongo): change Version() func to const Version string
Part of #8272