Fix panic for nil attributes and move convert funcs to internal/shared/logutil#6237
Fix panic for nil attributes and move convert funcs to internal/shared/logutil#6237pellared merged 8 commits intoopen-telemetry:mainfrom
Conversation
|
It would be better to put |
7d3a3be to
6aa37ba
Compare
|
@pellared just did it, also added some nil pointer test.
|
6aa37ba to
74ac4bf
Compare
pellared
left a comment
There was a problem hiding this comment.
Also this would leads to a semi-breaking change.
I think these changes are good 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6237 +/- ##
=======================================
+ Coverage 66.5% 66.9% +0.4%
=======================================
Files 188 190 +2
Lines 12456 12538 +82
=======================================
+ Hits 8284 8391 +107
+ Misses 3879 3856 -23
+ Partials 293 291 -2
|
|
Can you also please update the changelog and add an entry for each package where #6235 is fixed. |
98baa6a to
a1c5708
Compare
|
done |
a1c5708 to
36b6507
Compare
Co-authored-by: Robert Pająk <[email protected]>
|
you want |
Correct. We do not want to extend the exported API surface unless necessary. |
Co-authored-by: Robert Pająk <[email protected]>
fa5f4ff to
27601bc
Compare
|
just changed to private |
|
@m1heng, thank you very much for your contribution 🏅 |
Reuse convertValue in otelslog. Follows #6237.
### Added - Add the `WithSource` option to the `go.opentelemetry.io/contrib/bridges/otelslog` log bridge to set the `code.*` attributes in the log record that includes the source location where the record was emitted. (#6253) - Add `ContextWithStartTime` and `StartTimeFromContext` to `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp`, which allows setting the start time using go context. (#6137) - Set the `code.*` attributes in `go.opentelemetry.io/contrib/bridges/otelzap` if the `zap.Logger` was created with the `AddCaller` or `AddStacktrace` option. (#6268) - Add a `LogProcessor` to `go.opentelemetry.io/contrib/processors/baggagecopy` to copy baggage members to log records. (#6277) - Use `baggagecopy.NewLogProcessor` when configuring a Log Provider. - `NewLogProcessor` accepts a `Filter` function type that selects which baggage members are added to the log record. ### Changed - Transform raw (`slog.KindAny`) attribute values to matching `log.Value` types. For example, `[]string{"foo", "bar"}` attribute value is now transformed to `log.SliceValue(log.StringValue("foo"), log.StringValue("bar"))` instead of `log.String("[foo bar"])`. (#6254) - Upgrade `go.opentelemetry.io/otel/semconv/v1.17.0` to `go.opentelemetry.io/otel/semconv/v1.21.0` in `go.opentelemetry.io/contrib/instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo`. (#6272) - Resource doesn't merge with defaults if a valid resource is configured in `go.opentelemetry.io/contrib/config`. (#6289) ### Fixed - Transform nil attribute values to `log.Value` zero value instead of panicking in `go.opentelemetry.io/contrib/bridges/otellogrus`. (#6237) - Transform nil attribute values to `log.Value` zero value instead of panicking in `go.opentelemetry.io/contrib/bridges/otelzap`. (#6237) - Transform nil attribute values to `log.Value` zero value instead of `log.StringValue("<nil>")` in `go.opentelemetry.io/contrib/bridges/otelslog`. (#6246) - Fix `NewClientHandler` so that `rpc.client.request.*` metrics measure requests instead of responses and `rpc.client.responses.*` metrics measure responses instead of requests in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`. (#6250) - Fix issue in `go.opentelemetry.io/contrib/config` causing `otelprom.WithResourceAsConstantLabels` configuration to not be respected. (#6260) - `otel.Handle` is no longer called on a successful shutdown of the Prometheus exporter in `go.opentelemetry.io/contrib/config`. (#6299)
This pull request aligns the
convertValuefunction in theotellogruspackage with theotellogr.Also fix #6235