[BUILD] Remove CMAKE POLICY CMP0092#3741
Merged
marcalff merged 1 commit intoopen-telemetry:mainfrom Nov 10, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3741 +/- ##
=======================================
Coverage 90.01% 90.01%
=======================================
Files 225 225
Lines 7105 7105
=======================================
Hits 6395 6395
Misses 710 710 🚀 New features to boost your workflow:
|
owent
approved these changes
Nov 9, 2025
Member
owent
left a comment
owent
left a comment
There was a problem hiding this comment.
Should we add /W3 for MSVC when CMP0092 is NEW?
Member
Author
In There should be no need to have specific logic for this, in my understanding. |
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Nov 10, 2025
[BUILD] Remove CMAKE POLICY CMP0092 (open-telemetry#3741)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3711
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes