[Metrics] New Attribute Processor for Exclude list#3633
[Metrics] New Attribute Processor for Exclude list#3633marcalff merged 9 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3633 +/- ##
==========================================
- Coverage 90.05% 90.04% -0.00%
==========================================
Files 220 220
Lines 7081 7097 +16
==========================================
+ Hits 6376 6390 +14
- Misses 705 707 +2
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new FilteringExcludeAttributesProcessor class that filters out specified attributes from metrics, complementing the existing include-list functionality. The implementation follows the OpenTelemetry specification for stream configuration attribute filtering.
Key changes:
- Added
FilteringExcludeAttributesProcessorclass with exclude-list functionality - Implemented corresponding unit tests to validate the new processor behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
sdk/include/opentelemetry/sdk/metrics/view/attributes_processor.h |
Adds new FilteringExcludeAttributesProcessor class implementation |
sdk/test/metrics/attributes_processor_test.cc |
Adds unit tests for the new exclude-list attribute processor |
sdk/include/opentelemetry/sdk/metrics/view/attributes_processor.h
Outdated
Show resolved
Hide resolved
sdk/include/opentelemetry/sdk/metrics/view/attributes_processor.h
Outdated
Show resolved
Hide resolved
marcalff
left a comment
marcalff
left a comment
There was a problem hiding this comment.
Thanks for the fix.
The code looks ok, but the tests are inconclusive, and could be much stronger.
See comments.
4 participants
Fixes #3546
Changes
Created a new Attribute processor for exclude list as filter only partially exists for allowed list
This is the doc of spec - https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#stream-configuration
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes