[SDK] Implementation of container resource as per semconv by nikhilbhatia08 · Pull Request #3572 · open-telemetry/opentelemetry-cpp

nikhilbhatia08 · 2025-07-29T17:11:35Z

Fixes # (issue)
Partially fixes #3548

Changes

Added container resource detector only for collecting info about container.id from /proc/self/cgroup and added test coverage to it, but could not add test coverage to Detect() of ContainerResource

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

CHANGELOG.md updated for non-trivial changes
Unit tests have been added
Changes in public API reviewed

linux-foundation-easycla · 2025-07-29T17:11:39Z

The committers listed above are authorized under a signed CLA.

✅ login: dependabot[bot] (5ec872c)
✅ login: nikhilbhatia08 / name: Nikhil Bhatia (926517f, 00decf9, fd93b32, 0e7d011, f075c93, bd7a71c, a1778b9, c740ddb, a495294, 4bf2bfb, 72565ec, 7cbcc59, 2546661, 9e5bc55, 220a5ad, 439e92c, 9bc07e1, b030cc9, a404c80, edef26e, 018a1f8, 4cebe35, b84840f, 75c495c, 3742932)
✅ login: owent / name: WenTao Ou (f7b5e94)
✅ login: opentelemetrybot / name: OpenTelemetry Bot (81624a3)
✅ login: lalitb / name: Lalit Kumar Bhasin (047e35c, 86cebd6)
✅ login: markus456 / name: Markus Mäkelä (a836349)

netlify · 2025-07-29T17:11:40Z

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name	Link
🔨 Latest commit	`018a1f8`
🔍 Latest deploy log	https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/6898d0cd0f0daa00088d7918

codecov · 2025-07-29T17:37:13Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.08%. Comparing base (5f6d99f) to head (fd93b32).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3572      +/-   ##
==========================================
+ Coverage   90.03%   90.08%   +0.06%     
==========================================
  Files         220      222       +2     
  Lines        7069     7115      +46     
==========================================
+ Hits         6364     6409      +45     
- Misses        705      706       +1

Files with missing lines	Coverage Δ
resource_detectors/container_detector_utils.cc	`100.00% <100.00%> (ø)`
resource_detectors/test/container_detector_test.cc	`100.00% <100.00%> (ø)`
sdk/src/resource/resource_detector.cc	`100.00% <100.00%> (ø)`

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sdk/src/common/container.cc

sdk/src/resource/resource_detector.cc

sdk/include/opentelemetry/sdk/common/container.h

sdk/include/opentelemetry/sdk/resource/resource_detector.h

…hilbhatia08/opentelemetry-cpp into implement_resource_detectors

sdk/src/resource/resource.cc

sdk/src/resource/CMakeLists.txt

sdk/src/resource/container_detector.cc

dbarker · 2025-08-05T18:35:13Z

Thanks for the PR @nikhilbhatia08! I think we just need to hash out how best to include these "built-in" detectors in the repo/build systems since many will bring platform dependencies. I've posted my proposal to the initial issue thread.

hello changes some changes

…hilbhatia08/opentelemetry-cpp into implement_resource_detectors

Copilot

Pull Request Overview

This PR implements a container resource detector that extracts container IDs from cgroup information to comply with OpenTelemetry semantic conventions. The implementation focuses specifically on detecting the container.id attribute by parsing /proc/self/cgroup files.

Adds a new ContainerResourceDetector class that reads container ID from cgroup files
Implements helper functions for parsing container IDs from cgroup file lines using regex
Adds comprehensive test coverage for container ID extraction logic

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
resource_detectors/include/opentelemetry/resource_detectors/container_resource_detector.h	Header file defining the ContainerResourceDetector class and helper functions
resource_detectors/container_detector.cc	Implementation of the ContainerResourceDetector::Detect() method
resource_detectors/container.cc	Implementation of container ID extraction logic from cgroup files
resource_detectors/CMakeLists.txt	CMake configuration for the new resource_detectors library
resource_detectors/BUILD	Bazel build configuration for the resource_detectors library
sdk/test/resource/resource_test.cc	Test cases for container ID extraction functionality
sdk/test/resource/CMakeLists.txt	Updated test dependencies to include resource_detectors
sdk/test/resource/BUILD	Updated Bazel test dependencies
sdk/src/resource/resource_detector.cc	Refactored environment variable constants to use constexpr
CMakeLists.txt	Added resource_detectors subdirectory to build

resource_detectors/container.cc

resource_detectors/container_detector.cc

sdk/src/resource/resource_detector.cc

resource_detectors/container.cc

resource_detectors/include/opentelemetry/resource_detectors/container_resource_detector.h

sdk/test/resource/BUILD

CMakeLists.txt

resource_detectors/CMakeLists.txt

sdk/test/resource/CMakeLists.txt

resource_detectors/container_detector.cc

resource_detectors/include/opentelemetry/resource_detectors/container_resource_detector.h

resource_detectors/container_detector.cc

CMakeLists.txt

lalitb

LGTM, once preview flag is added and approved by @dbarker. Thanks @nikhilbhatia08 for contribution, nice work.

CMakeLists.txt

dbarker

Looks good! Thanks for the PR. Congrats on your first contribution! Looking forward to the next one :)

nikhilbhatia08 · 2025-08-10T17:22:52Z

Thank you so much, @dbarker, @lalitb, and @rafaelroquetto, for helping me with my first contribution! Really appreciate it :) Looking forward to contributing more.

[SDK] Implementation of container resource as per semconv

c740ddb

nikhilbhatia08 requested a review from a team as a code owner July 29, 2025 17:11

lalitb requested a review from Copilot July 29, 2025 17:55

This comment was marked as outdated.

Sign in to view

malkia reviewed Jul 29, 2025

View reviewed changes

sdk/src/common/container.cc Outdated Show resolved Hide resolved

lalitb reviewed Jul 29, 2025

View reviewed changes

sdk/src/resource/resource_detector.cc Outdated Show resolved Hide resolved

lalitb reviewed Jul 29, 2025

View reviewed changes

sdk/src/resource/resource_detector.cc Outdated Show resolved Hide resolved

[sdk] minor changes in format, linking and var naming

4bf2bfb

nikhilbhatia08 requested review from Copilot, lalitb and malkia July 30, 2025 12:26

This comment was marked as outdated.

Sign in to view

nikhilbhatia08 and others added 2 commits July 31, 2025 19:20

changes for ci

f075c93

Merge branch 'main' into implement_resource_detectors

86cebd6

lalitb reviewed Aug 2, 2025

View reviewed changes

sdk/include/opentelemetry/sdk/common/container.h Outdated Show resolved Hide resolved

sdk/include/opentelemetry/sdk/resource/resource_detector.h Outdated Show resolved Hide resolved

nikhilbhatia08 added 4 commits August 2, 2025 15:04

ci and requested changes

00decf9

Merge branch 'implement_resource_detectors' of https://github.com/nik…

b84840f

…hilbhatia08/opentelemetry-cpp into implement_resource_detectors

iwyu-fix

edef26e

newline-fix

3742932

dbarker reviewed Aug 3, 2025

View reviewed changes

sdk/src/resource/resource.cc Outdated Show resolved Hide resolved

dbarker reviewed Aug 3, 2025

View reviewed changes

sdk/src/resource/CMakeLists.txt Outdated Show resolved Hide resolved

dbarker reviewed Aug 3, 2025

View reviewed changes

sdk/src/resource/container_detector.cc Outdated Show resolved Hide resolved

nikhilbhatia08 and others added 4 commits August 7, 2025 15:07

newline-fix

a495294

hello changes some changes

Merge branch 'implement_resource_detectors' of https://github.com/nik…

72565ec

…hilbhatia08/opentelemetry-cpp into implement_resource_detectors

[EXPORTER] Fixes tsan warnings (open-telemetry#3531)

f7b5e94

[DOC] Document minimum required versions (open-telemetry#3562)

a836349

lalitb requested a review from Copilot August 8, 2025 17:49

Copilot AI reviewed Aug 8, 2025

View reviewed changes

resource_detectors/container.cc Show resolved Hide resolved

lalitb reviewed Aug 8, 2025

View reviewed changes

resource_detectors/container_detector.cc Outdated Show resolved Hide resolved

constants naming fix

a404c80

lalitb reviewed Aug 8, 2025

View reviewed changes

sdk/src/resource/resource_detector.cc Outdated Show resolved Hide resolved

sdk/src/resource/resource_detector.cc Outdated Show resolved Hide resolved

lalitb reviewed Aug 8, 2025

View reviewed changes

resource_detectors/container.cc Show resolved Hide resolved

lalitb reviewed Aug 8, 2025

View reviewed changes

resource_detectors/include/opentelemetry/resource_detectors/container_resource_detector.h Outdated Show resolved Hide resolved

lalitb reviewed Aug 8, 2025

View reviewed changes

sdk/test/resource/BUILD Outdated Show resolved Hide resolved