[SDK] Add logger scope configurator#3282
Merged
marcalff merged 16 commits intoopen-telemetry:mainfrom Mar 20, 2025
Merged
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3282 +/- ##
==========================================
+ Coverage 89.48% 89.50% +0.03%
==========================================
Files 208 210 +2
Lines 6497 6522 +25
==========================================
+ Hits 5813 5837 +24
- Misses 684 685 +1
🚀 New features to boost your workflow:
|
psx95
force-pushed
the
add-logger-scope-config
branch
2 times, most recently
from
0c57591 to
852a3c9
Compare
psx95
force-pushed
the
add-logger-scope-config
branch
from
20904c6 to
7290f73
Compare
Comparison of timestamps has been moved from GT to GE since depending on the machine, the operations may execute within 1 ns, which is lower than the resolution of time being captured.
owent
reviewed
Mar 15, 2025
owent
reviewed
Mar 15, 2025
marcalff
approved these changes
Mar 20, 2025
Member
marcalff
left a comment
marcalff
left a comment
There was a problem hiding this comment.
LGTM, thanks for the feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2641
Adds scope configurator for Loggers.
Similar work was done for Tracers in #3137 and Meters in #3268.
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes