[SDK] Do not frequently create and destroy http client threads#3198
Merged
marcalff merged 17 commits intoopen-telemetry:mainfrom Dec 18, 2024
Merged
[SDK] Do not frequently create and destroy http client threads#3198marcalff merged 17 commits intoopen-telemetry:mainfrom
marcalff merged 17 commits intoopen-telemetry:mainfrom
Conversation
|
|
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
xiehuc
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3198 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 195 195
Lines 6154 6154
=======================================
Hits 5405 5405
Misses 749 749 |
owent
changed the title
owent
requested changes
Dec 10, 2024
xiehuc
changed the title
owent
requested changes
Dec 12, 2024
ext/include/opentelemetry/ext/http/client/curl/http_client_curl.h
Outdated
Show resolved
Hide resolved
xiehuc
changed the title
xiehuc
changed the title
owent
approved these changes
Dec 12, 2024
Member
owent
left a comment
owent
left a comment
There was a problem hiding this comment.
LGTM and thanks for your contribution.
owent
changed the title
marcalff
changed the title
marcalff
changed the title
marcalff
reviewed
Dec 17, 2024
ext/include/opentelemetry/ext/http/client/curl/http_client_curl.h
Outdated
Show resolved
Hide resolved
marcalff
reviewed
Dec 17, 2024
marcalff
reviewed
Dec 17, 2024
marcalff
reviewed
Dec 17, 2024
Member
marcalff
left a comment
marcalff
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix.
See minor comments about missing wakeupBackgroundThread(), will approve once fixed.
Member
|
CI failures in functional tests are unrelated, it also fails in main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3189
Changes
keep the background thread for a while and destroy only when it's free for 1 minute.
Just like the background thread in OTLP file exporter.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes