[TEST] add a test for ElasticSearchRecordable#3154
Merged
marcalff merged 3 commits intoopen-telemetry:mainfrom Nov 22, 2024
Merged
[TEST] add a test for ElasticSearchRecordable#3154marcalff merged 3 commits intoopen-telemetry:mainfrom
marcalff merged 3 commits intoopen-telemetry:mainfrom
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
sjinks
commented
Nov 20, 2024
sjinks
commented
Nov 20, 2024
sjinks
commented
Nov 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3154 +/- ##
=======================================
Coverage 87.86% 87.86%
=======================================
Files 195 195
Lines 6151 6151
=======================================
Hits 5404 5404
Misses 747 747
|
Contributor
Author
|
Bazel on MacOS and IWYU failed for unrelated to this PR reasons; I cannot restart these jobs. |
marcalff
changed the title
Member
|
Waiting a bit for possible comments, then will merge. |
lalitb
approved these changes
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a test for
opentelemetry::exporter::logs::ElasticSearchRecordableand updates the (disabled) tests for Elasticsearch Logs Exporter to ensure they compile.The plan is to refactor the ES Recordable to use the ADL Serializer. This will make the code much more readable and maintainable (no need to use
nostd::holds_alternativeorvalue.index()+nostd::get()and keep the list of the types up-to-date). That is why we need a test to make sure that the refactoring will not break the things.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes