[EXPORTER] Add config options to prometheus exporter#3104
Merged
marcalff merged 7 commits intoopen-telemetry:mainfrom Oct 21, 2024
Merged
[EXPORTER] Add config options to prometheus exporter#3104marcalff merged 7 commits intoopen-telemetry:mainfrom
marcalff merged 7 commits intoopen-telemetry:mainfrom
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3104 +/- ##
==========================================
+ Coverage 87.12% 87.91% +0.79%
==========================================
Files 200 195 -5
Lines 6109 6133 +24
==========================================
+ Hits 5322 5391 +69
+ Misses 787 742 -45 |
psx95
changed the title
psx95
force-pushed
the
update-prometheus-exporter
branch
from
359f751 to
19d20cf
Compare
marcalff
reviewed
Oct 20, 2024
Member
marcalff
left a comment
marcalff
left a comment
There was a problem hiding this comment.
Thanks for the fix.
Please fix minor comments on the code flow.
Will approve after that.
marcalff
changed the title
psx95
force-pushed
the
update-prometheus-exporter
branch
from
012384a to
618f850
Compare
Contributor
Author
|
Thanks for the reviews! I made the requested changes. I sometimes find double negatives in if conditions a little unreadable, hopefully the small comments on top would make things clear. |
marcalff
added
the
ok-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2453
Changes
Added the following optional configuration options (booleans) to the prometheus exporter:
without_units: controls whether to add unit suffixes (e.g._seconds) to the metric names.without_type_suffix: controls whether to add type suffixes (e.g._total) to the metric names.CHANGELOG.mdupdated for non-trivial changes