[BUILD] Add a CMake option to disable shared libs#3095
Merged
marcalff merged 5 commits intoopen-telemetry:mainfrom Oct 21, 2024
Merged
[BUILD] Add a CMake option to disable shared libs#3095marcalff merged 5 commits intoopen-telemetry:mainfrom
marcalff merged 5 commits intoopen-telemetry:mainfrom
Conversation
This option is useful to support platforms that do not support dynamic libraries and `dlopen`.
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3095 +/- ##
==========================================
+ Coverage 87.12% 87.91% +0.79%
==========================================
Files 200 195 -5
Lines 6109 6133 +24
==========================================
+ Hits 5322 5391 +69
+ Misses 787 742 -45 |
Member
|
Is this PR not finished yet? All |
Contributor
Author
|
It is finished. The option only makes sense to use without |
lalitb
reviewed
Oct 14, 2024
marcalff
changed the title
ThomsonTan
reviewed
Oct 16, 2024
ThomsonTan
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option is useful to support platforms that do not support dynamic libraries and
dlopen.Fixes # (issue)
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes