Merged
Conversation
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2995 +/- ##
==========================================
+ Coverage 87.12% 87.67% +0.55%
==========================================
Files 200 190 -10
Lines 6109 5853 -256
==========================================
- Hits 5322 5131 -191
+ Misses 787 722 -65 |
ThomsonTan
reviewed
Jul 8, 2024
keith
force-pushed
the
ks/ci-enable-bzlmod
branch
from
18cc5fb to
9f3b932
Compare
keith
commented
Jul 12, 2024
|
|
||
| # Workaround https://github.com/bazelbuild/bazel/issues/18683 | ||
| $BAZEL_STARTUP_OPTIONS = "--output_base=C:\Out" | ||
| $BAZEL_OPTIONS = "--copt=-DENABLE_ASYNC_EXPORT" |
Contributor
Author
There was a problem hiding this comment.
this continues to be a wild hack. I linked the new path issue in the upstream issue, it should be improved once grpc moves its deps into bzlmod, but right now the paths are artificially longer. absolutely wild stuff.
marcalff
reviewed
Jul 12, 2024
Member
|
Also, "This branch is out-of-date with the base branch", please merge recent changes from main. |
marcalff
approved these changes
Jul 12, 2024
Member
marcalff
left a comment
marcalff
left a comment
There was a problem hiding this comment.
Not a bazel expert, but looks ok to me.
Thanks for the work on bazel, with supporting PRs in BCR.
Somehow I missed this in my PR adding support for bzlmod
keith
force-pushed
the
ks/ci-enable-bzlmod
branch
from
1a0153b to
d467164
Compare
Contributor
Author
|
green after rebase! 🎉 |
ThomsonTan
approved these changes
Jul 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow I missed this in my PR adding support for bzlmod