Skip to content

[REMOVAL] Remove build option WITH_DEPRECATED_SDK_FACTORY#2717

Merged
marcalff merged 9 commits intoopen-telemetry:mainfrom
marcalff:deprecated_sdk_removal_2716
Jul 17, 2024
Merged

[REMOVAL] Remove build option WITH_DEPRECATED_SDK_FACTORY#2717
marcalff merged 9 commits intoopen-telemetry:mainfrom
marcalff:deprecated_sdk_removal_2716

Conversation

@marcalff
Copy link
Member

@marcalff marcalff commented Jun 25, 2024 •
edited
Loading

Fixes #2716

Changes

Please provide a brief description of the changes here.

  • Removed CMake option WITH_DEPRECATED_SDK_FACTORY
  • Removed old references to CMake option WITH_OTLP
  • Removed old references to CMake option WITH_LOGS_PREVIEW

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff added the removal Removal label Jun 25, 2024
@codecov
Copy link

codecov bot commented Jun 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.66%. Comparing base (497eaf4) to head (87b00e9).
Report is 105 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2717      +/-   ##
==========================================
+ Coverage   87.12%   87.66%   +0.55%     
==========================================
  Files         200      190      -10     
  Lines        6109     5858     -251     
==========================================
- Hits         5322     5135     -187     
+ Misses        787      723      -64
Files Coverage Δ
sdk/src/logs/event_logger_provider_factory.cc 100.00% <ø> (ø)
sdk/src/trace/tracer_provider_factory.cc 44.83% <ø> (+0.39%) ⬆️

... and 119 files with indirect coverage changes

@marcalff marcalff marked this pull request as ready for review June 25, 2024 22:48
@marcalff marcalff requested a review from a team June 25, 2024 22:48
@marcalff marcalff added the pr:please-review This PR is ready for review label Jun 25, 2024
@marcalff
Copy link
Member Author

marcalff commented Jun 25, 2024

Please review.

I suggest to wait at one or two weeks for possible comments on this (the removal issue is pinned), before merging to main.

ThomsonTan
ThomsonTan reviewed Jun 26, 2024
View reviewed changes
@ThomsonTan
Copy link
Contributor

ThomsonTan commented Jul 15, 2024

Should this PR be included in the coming minor build (like 1.7.0) instead of patch build?

@marcalff
Copy link
Member Author

marcalff commented Jul 16, 2024

Should this PR be included in the coming minor build (like 1.7.0) instead of patch build?

Current release is 1.16.0, so next patch build will be 1.16.1

This removal should only be part of release 1.17.0, and not part of the 1.16.1 patch, I agree.

ThomsonTan
ThomsonTan approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@ThomsonTan ThomsonTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one note is to merging this after the patch release of 1.6.1.

@marcalff marcalff added pr:do-not-merge This PR is not ready to be merged. and removed pr:please-review This PR is ready for review labels Jul 17, 2024
@marcalff marcalff removed the pr:do-not-merge This PR is not ready to be merged. label Jul 17, 2024
@marcalff marcalff merged commit 611906e into open-telemetry:main Jul 17, 2024
@BrewTestBot BrewTestBot mentioned this pull request Oct 8, 2024
Merged
@marcalff marcalff deleted the deprecated_sdk_removal_2716 branch February 5, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees

No one assigned

Labels

removal Removal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[REMOVAL] Remove build option WITH_DEPRECATED_SDK_FACTORY

2 participants

@marcalff @ThomsonTan