feat: add contract-review-dag cookbook example with step-level retry#155
Conversation
JackChen-me
left a comment
JackChen-me
left a comment
There was a problem hiding this comment.
Traced the FORCE_FAIL path, works (beforeRun throw → Agent returns success:false → executeWithRetry retries).
Main thing: the README update from issue #136 AC is missing. Add an entry in examples/README.md matching the style of the other two cookbook entries, mention both run modes.
Two cleanups: setTimeout(resolve, 100) before verifyParallelism is unnecessary since onProgress fires synchronously. The "Read the clause list from shared memory" phrasing in task descriptions is misleading too; default memoryScope is 'dependencies', so dep results are injected into the prompt and the agent isn't reading memory as an action. Reword to "Using the clause list from Task 1 above" or similar.
fault-segment
force-pushed
the
example/contract-review
branch
from
53e1c4c to
867bfd8
Compare
|
thx for detailed review.I've fix them,add the example in the README.md,remove the setTimeout and fix the task desc. |
|
LGTM, hits #136. One ask: the parallelism check logs |
|
Fixed that.Now it's anassertion and newlines added. |
JackChen-me
left a comment
JackChen-me
left a comment
There was a problem hiding this comment.
All feedback addressed — README entry, setTimeout removed, task descriptions reworded, parallelism assertion added, trailing newlines. Thanks!
2 participants
What
This PR add an contract review pipeline with task DAG example.Parallel execution and forced retries were verified.
Why
Complete this Issue #136
Checklist
npm run lintpassesnpm testpassesExample Result: