feat: add 11 Google Workspace apps and inline BYOC config dialog#140
Merged
feat: add 11 Google Workspace apps and inline BYOC config dialog#140
Conversation
- Add Google Docs, Sheets, Slides, Tasks, Forms, Classroom, Admin, Analytics, Search Console, Meet, and Photos as OAuth integrations - Extract shared Google OAuth helpers (buildAuthUrl, exchangeCode) to reduce duplication across 13 Google app definitions - Downgrade scopes to match approved Google verification: Gmail uses gmail.readonly/modify/send, Calendar uses calendar.readonly/events, Drive/Docs/Sheets/Slides use drive.readonly/drive.file - Apps without approved scopes (Tasks, Forms, etc.) require BYOC credentials — no platform defaults - Add inline BYOC config dialog: clicking Connect on an unconfigured app shows a Client ID/Secret form, then opens the OAuth popup - Fix gateway multi-rule injection: providers with multiple host rules on the same host (e.g., Drive /drive/ + /upload/drive/) now produce separate injection rules for each path prefix - Extract shared RefreshConfig constant for all Google providers - Make envDefaults optional in AppDefinition for BYOC-only apps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildGoogleAuthUrl,exchangeGoogleCode,googleConfigFieldsintogoogle-oauth.tsto eliminate duplication across 13 app definitionsgmail.readonly/modify/send, Calendar usescalendar.readonly/events, Drive/Docs/Sheets/Slides usedrive.readonly/drive.file— matching approved Google verification scopes/drive/+/upload/drive/) now produce separate injection rules for each path prefix via newbuild_app_injection_rulesfunctionGOOGLE_REFRESHconstant replaces 13 identical inline blocksconfigurable.envDefaultsis now optional for BYOC-only appsTest plan
pnpm checkpasses (lint, types, format)cargo testpasses (126 tests including new Drive multi-rule test + workspace provider tests)/drive/*and/upload/drive/*paths