fix: preserve Content-Length header in MITM responses#102
Merged
Conversation
723f061 to
6533176
Compare
hisgarden
pushed a commit
to hisgarden/onecli
that referenced
this pull request
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have read the CONTRIBUTING.md file.
YES
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The gateway's hop-by-hop header filter strips
Content-Lengthfrom both request and response headers. This breaks HEAD responses — clients likehuggingface_hubthat rely onContent-Lengthin HEAD responses to resolve model file sizes get empty values.Closes #101
What is the new behavior?
Split
is_forwarded_headerinto two focused functions:is_forwarded_request_header— stripsContent-Length(reqwest recalculates it from the body)is_forwarded_response_header— preservesContent-Length(required for HEAD responses and correct HTTP/1.1 framing)Shared
HOP_BY_HOP_HEADERSconstant eliminates duplication between the two functions.Additional context