Conversation
wilbeibi
force-pushed
the
fix/daytona-resumable-sandboxes
branch
from
September 19, 2026 02:35
7d96828 to
896b718
Compare
A managed wake could replace a stopped or archived Daytona sandbox, discarding its persisted workspace. Wakes could also race provider-owned stop/archive transitions, while temporary lookup failures risked being confused with definitive deletion. Resume the recorded sandbox under the same ID, wait through transitional states with an archive-aware timeout, and reserve SandboxGoneError for confirmed deletion. Ordinary provider failures keep the existing binding for a later retry. Part of omnigent-ai#4676. A non-destructive park operation remains out of scope. Verified with 42 targeted launcher and shared-wake tests, the complete pre-commit suite, and a live Daytona stop/archive/resume smoke that preserved a sentinel under the same sandbox ID. Signed-off-by: Hongyi Shen <[email protected]>
wilbeibi
force-pushed
the
fix/daytona-resumable-sandboxes
branch
from
September 19, 2026 02:43
896b718 to
08455a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Part of #4676
Summary
ELI5: if a workspace is asleep, wake it up. Build a new one only if the old one was deleted.
Start review in
omnigent/onboarding/sandboxes/daytona.py; the remaining changes are focused tests and the Daytona README update.This does not add the separate park operation requested in #4676, so the issue should remain open.
Test Plan
uv run --group test pytest tests/onboarding/sandboxes/test_daytona.py tests/server/test_managed_hosts.py -q -k 'test_daytona or resume_managed_host or run_managed_wake_recreates_a_definitively_gone_sandbox'42 passed, 356 deselecteduv run --group dev pre-commit run --all-filesDemo
Type of change
Test coverage
Coverage notes
The tests cover archived resume, a wake racing an archive, deleted sandboxes, and temporary API failures. The live check used the real Daytona API and confirmed that both the sandbox ID and its file survived stop and archive. No credential is stored in the repository or test fixtures.
Changelog
Daytona managed sessions now keep their workspace when a stopped or archived sandbox resumes.