Issue 948 radon scaling #958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kohr-h
approved these changes
Mar 16, 2017
Member
kohr-h
left a comment
kohr-h
left a comment
There was a problem hiding this comment.
Looking good, apart from minor things
odl/tomo/backends/astra_cuda.py
Outdated
| @@ -281,7 +281,8 @@ def call_backward(self, proj_data, out=None): | |||
| out[:] = self.out_array | |||
|
|
|||
| # Fix inconsistent scaling in ASTRA | |||
Member
There was a problem hiding this comment.
Can we remove these comments? It's largely been reduced to different conventions, no? No more need to be cocky.
odl/tomo/operators/ray_trafo.py
Outdated
| size = float(geometry.partition.size) | ||
| weighting = extent / size | ||
| else: | ||
| raise ValueError('unknown weighting of domain') |
Member
Author
There was a problem hiding this comment.
Frankly, no. This case currently cannot happen, so I'll change it to NotImplementedError and leave it at that.
|
|
||
|
|
||
| @skip_if_no_largescale | ||
| def test_reconstruction(projector): |
Member
Author
|
Merge after CI. |
adler-j
force-pushed
the
issue-948__radon_scaling
branch
from
387a945 to
cd7da24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.