BUG: fix bad return of in-place ReductionOperator #1010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kohr-h
force-pushed
the
fix_reduction_inplace
branch
from
534a2cd to
cb78e5b
Compare
adler-j
approved these changes
May 28, 2017
Member
adler-j
left a comment
adler-j
left a comment
There was a problem hiding this comment.
Nice catch. Some minor stuff and then go.
| >>> op([[1.0, 2.0, 3.0], | ||
| ... [4.0, 6.0, 8.0]]) | ||
| rn(3).element([9.0, 14.0, 19.0]) | ||
| >>> out = op.range.element() |
Member
There was a problem hiding this comment.
If you are going to add a oop example, then make it independent, i.e. add a separate title "In place evaulation also works" or something like that
odl/operator/pspace_ops.py
Outdated
| else: | ||
| wrapped_out = self.prod_op.range.element([out], cast=False) | ||
| return self.prod_op(x, out=wrapped_out) | ||
| result = self.prod_op(x, out=wrapped_out) |
Member
|
Could you try to get this out of the way? |
kohr-h
force-pushed
the
fix_reduction_inplace
branch
from
b6d0841 to
ba1ab94
Compare
Member
Author
|
Fixed and rebased, will merge when CI goes green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added check that
outis returned captured this bug (albeit somewhat late since there were no tests).