Replace gofmt by goimports and move the imports the template - #226
Merged
1 commit merged intoSep 4, 2020
Merged
1 commit merged into
1 commit merged into
Conversation
|
Nice! Thanks. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is great project with a lot of potential! In this PR I've tried to add my little contribution:
Replaced
gofmtbygoimports:goimportsdoes everything thatgofmtdo but it also groups and corrects imported packages. This will make the generated code nicer to read and reduce the probability of having a missing/incorrect import statement.Removed the imports list (and the related code) from the source code and moved them to the template.
goimportswill automatically "clean" the import section. This will make the templates more easily customizable (devs can add imports) without the need of modifying the import list in the source code.