fix(templates): correctly nil check arrays #2118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of #2031, we need to correct a subtle breakage in #1981, where we would not correctly perform the nil check on arrays, breaking marshalling functionality. As a first step, we add a new helper method to inform as to whether the zero value of a Property could be `nil`, and therefore needs a `nil` check.
As part of #2031, we need to correct a subtle breakage in #1981, where we would not correctly perform the nil check on arrays, breaking marshalling functionality. As a first step, we add a new helper method to be used to validate whether a `nil` check is required on a given type, which is used for either types with a zero value of `nil`, or where we have an optional pointer set.
As part of #2031, we need to correct a subtle breakage in #1981, where we would not correctly perform the nil check on arrays, breaking marshalling functionality. To do this we can modify our templates to call the newly added `RequiresNilCheck` when performing nil checks Closes #2031. Co-authored-by: Matthew Gabeler-Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #2031, this was a regression.
To fix this, we'll add some additional template helpers to consolidate and clarify this.
Closes #2031.