Skip to content

Avoid extra http.Request allocation (stdhttp, chi, gorilla) #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mromaszewicz merged 1 commit into from
Jun 28, 2024
Merged

Avoid extra http.Request allocation (stdhttp, chi, gorilla) #1673

mromaszewicz merged 1 commit into from
Jun 28, 2024

Conversation

@gaiaz-iusipov
Copy link
Contributor

@gaiaz-iusipov gaiaz-iusipov commented Jun 28, 2024

There is no reason to reallocate http.Request when no SecurityDefinitions are provided.

@gaiaz-iusipov gaiaz-iusipov requested a review from a team as a code owner June 28, 2024 10:27
@mromaszewicz
Copy link
Member

mromaszewicz commented Jun 28, 2024

Thank you.

@mromaszewicz mromaszewicz merged commit 01d6156 into oapi-codegen:main Jun 28, 2024
@jamietanna jamietanna added the chore Any maintenance tasks that are regular, not as important to call out in the changelog label Jul 12, 2024
This was referenced Sep 28, 2024
Merged
Merged
@jamietanna jamietanna mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mromaszewicz mromaszewicz mromaszewicz approved these changes

Assignees

No one assigned

Labels

chore Any maintenance tasks that are regular, not as important to call out in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gaiaz-iusipov @mromaszewicz @jamietanna