Fix: Handle code generation for all multipart content-types #1385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamietanna
changed the title
ShouheiNishi
added a commit
to ShouheiNishi/oapi-codegen
that referenced
this pull request
Dec 28, 2023
…i-codegen#1385) Right now, we're only generating code for multipart requests when the media type is a `multipart/form-data`, which means that other multipart types, like `multipart/related` do not correctly generate. We should amend this, generating code that validates the media type provided and handling the request. Closes oapi-codegen#1381.
danicc097
pushed a commit
to danicc097/oapi-codegen
that referenced
this pull request
Aug 31, 2024
…i-codegen#1385) Right now, we're only generating code for multipart requests when the media type is a `multipart/form-data`, which means that other multipart types, like `multipart/related` do not correctly generate. We should amend this, generating code that validates the media type provided and handling the request. Closes oapi-codegen#1381.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current code, functions http.Request.MultipartReader() and multipart.Writer.FormDataContentType() are used for the processing of the mutlipart message, but this function is only supported when contentType is "multipart/form-data".
When contentType is specified in OpenAPI definition other than "multipart/form-data", code that compatible with other contentTypes is generated without using these functions.
This PR fix #1381.