feat: add ability to tweak generated names (including use of initialisms) #1041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 5, 2023 12:56
wtertius
force-pushed
the
generate_names_with_initialisms_wo_bc
branch
from
2e92b52 to
7bfbe37
Compare
wtertius
force-pushed
the
generate_names_with_initialisms_wo_bc
branch
from
7bfbe37 to
c1467da
Compare
|
Can we merge this PR? @jamietanna, cant I help somehow to merge this PR? |
jamietanna
reviewed
May 4, 2024
Member
|
Thanks very much for this @wtertius 💜 This is a great solution - I've made a couple of tweaks to add additional test cases + some new docs (alongside recent project changes) and will merge it shortly |
jamietanna
approved these changes
May 4, 2024
jamietanna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support of three naming styles:
By the steps of Generate names with initialisms #749 but without breaking changes.