Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4
Check the README for information on the plugin.
Any feedback will be appreciated. Next tasks on my to-do list are code cleanup and adding HTTP/S support to at least get the player list in JSON format.
If anyone can find a way to reliably detect chat messages (shout/DM/tell channels) without using exclusive hooks it'd help a lot. Right now the only way I found is hooking
CNWSMessage::HandlePlayerToServerChatMessage()but it has to be an exclusive hook because some information is extracted from theCNWSMessagethrough destructive operations.