nvim-java · s1n7ax · Jun 12, 2026 · Jun 12, 2026 · Jun 12, 2026
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -9,7 +9,9 @@ on:
 jobs:
   test:
     runs-on: ${{ matrix.os }}
+    timeout-minutes: 40
     strategy:
+      fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
         nvim-versions: ["stable", "nightly"]

diff --git a/.luacheckrc b/.luacheckrc
@@ -5,6 +5,7 @@ globals = {
 	'vim.bo',
 	'vim.opt',
 	'vim.lsp',
+	'vim.ui',
 }
 read_globals = {
 	'vim',

diff --git a/CLAUDE.md b/CLAUDE.md
@@ -76,22 +76,22 @@ plugin/java.lua           # User command registration
 
 ```
 tests/
-├── assets/           # Test fixtures and assets (e.g., HelloWorld.java)
-├── constants/        # Test constants (e.g., capabilities.lua)
+├── fixtures/         # Test projects (e.g., demo/ - Maven project with JUnit tests)
 ├── utils/            # Test utilities and config files
 │   ├── lsp-utils.lua      # LSP test helpers
+│   ├── project.lua        # Fixture project + wait/assert helpers
 │   ├── prepare-config.lua # Lazy.nvim test setup
-│   └── test-config.lua    # Manual test setup
+│   └── test-config.lua    # Minimal init for plenary child nvim
 └── specs/            # Test specifications
-    ├── lsp_spec.lua       # All LSP-related tests
-    └── pkgm_spec.lua      # All pkgm-related tests
+    └── integration_spec.lua # End-to-end plugin feature tests
 ```
 
 **Test Guidelines:**
-- Group related tests in single spec file (e.g., all pkgm tests in `pkgm_spec.lua`)
+- Tests are end-to-end: real Neovim + real JDTLS against fixture Maven project
+- Fixture projects are copied to a temp dir at runtime (root markers prefer `.git`, so they must run outside the repo)
+- Spec `it` blocks run sequentially and share JDTLS session state; order matters
 - Extract reusable logic to `utils/` to keep test steps clean
-- Store test data/fixtures in `assets/`
-- Store constants (capabilities, expected values) in `constants/`
+- Store test projects in `fixtures/`
 
 ## Code Patterns
 

diff --git a/Makefile b/Makefile
@@ -3,7 +3,7 @@ TESTS_ROOT=tests
 TESTS_DIR?=${TESTS_ROOT}/specs
 PREPARE_CONFIG=${TESTS_ROOT}/utils/prepare-config.lua
 TEST_CONFIG=${TESTS_ROOT}/utils/test-config.lua
-TEST_TIMEOUT?=60000
+TEST_TIMEOUT?=600000
 
 .PHONY: test tests lint format all
 

diff --git a/lua/pkgm/downloaders/curl.lua b/lua/pkgm/downloaders/curl.lua
@@ -39,13 +39,17 @@ end
 ---@return string|nil # Error message if failed
 function Curl:download()
 	log.debug('curl downloading:', self.url, 'to', self.dest)
-	local cmd = string.format(
-		'curl --retry %d --connect-timeout %d -o %s %s',
-		self.retry_count,
-		self.timeout,
-		vim.fn.shellescape(self.dest),
-		vim.fn.shellescape(self.url)
-	)
+	-- argv list so no shell quoting is involved
+	local cmd = {
+		'curl',
+		'--retry',
+		tostring(self.retry_count),
+		'--connect-timeout',
+		tostring(self.timeout),
+		'-o',
+		self.dest,
+		self.url,
+	}
 	log.debug('curl command:', cmd)
 
 	local result = vim.fn.system(cmd)

diff --git a/lua/pkgm/downloaders/powershell.lua b/lua/pkgm/downloaders/powershell.lua
@@ -49,12 +49,19 @@ function PowerShell:download()
 		self.dest
 	)
 
-	local cmd = string.format(
-		-- luacheck: ignore
-		"%s -NoProfile -NonInteractive -Command \"$ProgressPreference = 'SilentlyContinue'; $ErrorActionPreference = 'Stop'; [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; %s\"",
+	-- pass an argv list so no shell is involved; a single command string
+	-- breaks when &shell is pwsh (nvim nightly default on Windows)
+	local cmd = {
 		pwsh,
-		pwsh_cmd
-	)
+		'-NoProfile',
+		'-NonInteractive',
+		'-Command',
+		string.format(
+			-- luacheck: ignore
+			"$ProgressPreference = 'SilentlyContinue'; $ErrorActionPreference = 'Stop'; [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; %s",
+			pwsh_cmd
+		),
+	}
 	log.debug('PowerShell command:', cmd)
 
 	local result = vim.fn.system(cmd)

diff --git a/lua/pkgm/downloaders/wget.lua b/lua/pkgm/downloaders/wget.lua
@@ -39,13 +39,17 @@ end
 ---@return string|nil # Error message if failed
 function Wget:download()
 	log.debug('wget downloading:', self.url, 'to', self.dest)
-	local cmd = string.format(
-		'wget -t %d -T %d -O %s %s',
-		self.retry_count,
-		self.timeout,
-		vim.fn.shellescape(self.dest),
-		vim.fn.shellescape(self.url)
-	)
+	-- argv list so no shell quoting is involved
+	local cmd = {
+		'wget',
+		'-t',
+		tostring(self.retry_count),
+		'-T',
+		tostring(self.timeout),
+		'-O',
+		self.dest,
+		self.url,
+	}
 	log.debug('wget command:', cmd)
 
 	local result = vim.fn.system(cmd)

diff --git a/lua/pkgm/extractors/powershell.lua b/lua/pkgm/extractors/powershell.lua
@@ -42,12 +42,19 @@ function PowerShellExtractor:extract()
 		self.dest
 	)
 
-	local cmd = string.format(
-		--luacheck: ignore
-		"%s -NoProfile -NonInteractive -Command \"$ProgressPreference = 'SilentlyContinue'; $ErrorActionPreference = 'Stop'; %s\"",
+	-- pass an argv list so no shell is involved; a single command string
+	-- breaks when &shell is pwsh (nvim nightly default on Windows)
+	local cmd = {
 		pwsh,
-		pwsh_cmd
-	)
+		'-NoProfile',
+		'-NonInteractive',
+		'-Command',
+		string.format(
+			-- luacheck: ignore
+			"$ProgressPreference = 'SilentlyContinue'; $ErrorActionPreference = 'Stop'; %s",
+			pwsh_cmd
+		),
+	}
 	log.debug('PowerShell command:', cmd)
 
 	local result = vim.fn.system(cmd)

diff --git a/lua/pkgm/extractors/tar.lua b/lua/pkgm/extractors/tar.lua
@@ -37,27 +37,24 @@ function Tar:extract()
 	log.debug('tar extracting:', self.source, 'to', self.dest)
 	log.debug('Using tar binary:', tar_cmd)
 
-	local cmd
+	local source = self.source
+	local dest = self.dest
+
+	-- argv list so no shell quoting is involved (&shell may be pwsh on
+	-- Windows nvim nightly)
+	local cmd = { tar_cmd, '--no-same-owner' }
+
 	if system.get_os() == 'win' then
 		-- Windows: convert backslashes to forward slashes (tar accepts them)
-		local source = self.source:gsub('\\', '/')
-		local dest = self.dest:gsub('\\', '/')
-		cmd = string.format(
-			'%s --no-same-owner %s -xf "%s" -C "%s"',
-			tar_cmd,
-			self:tar_supports_force_local(tar_cmd) and '--force-local' or '',
-			source,
-			dest
-		)
-	else
-		-- Unix: use shellescape
-		cmd = string.format(
-			'%s --no-same-owner -xf %s -C %s',
-			tar_cmd,
-			vim.fn.shellescape(self.source),
-			vim.fn.shellescape(self.dest)
-		)
+		source = source:gsub('\\', '/')
+		dest = dest:gsub('\\', '/')
+
+		if self:tar_supports_force_local(tar_cmd) then
+			table.insert(cmd, '--force-local')
+		end
 	end
+
+	vim.list_extend(cmd, { '-xf', source, '-C', dest })
 	log.debug('tar command:', cmd)
 
 	local result = vim.fn.system(cmd)

diff --git a/lua/pkgm/extractors/unzip.lua b/lua/pkgm/extractors/unzip.lua
@@ -21,7 +21,8 @@ end
 ---@return string|nil # Error message if failed
 function Unzip:extract()
 	log.debug('unzip extracting:', self.source, 'to', self.dest)
-	local cmd = string.format('unzip -q -o %s -d %s', vim.fn.shellescape(self.source), vim.fn.shellescape(self.dest))
+	-- argv list so no shell quoting is involved
+	local cmd = { 'unzip', '-q', '-o', self.source, '-d', self.dest }
 	log.debug('unzip command:', cmd)
 
 	local result = vim.fn.system(cmd)

diff --git a/tests/constants/capabilities.lua b/tests/constants/capabilities.lua
diff --git a/tests/fixtures/demo/pom.xml b/tests/fixtures/demo/pom.xml
@@ -0,0 +1,25 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+	<modelVersion>4.0.0</modelVersion>
+
+	<groupId>com.example</groupId>
+	<artifactId>demo</artifactId>
+	<version>1.0.0</version>
+	<packaging>jar</packaging>
+
+	<properties>
+		<maven.compiler.release>17</maven.compiler.release>
+		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+	</properties>
+
+	<dependencies>
+		<dependency>
+			<groupId>org.junit.jupiter</groupId>
+			<artifactId>junit-jupiter</artifactId>
+			<version>5.10.2</version>
+			<scope>test</scope>
+		</dependency>
+	</dependencies>
+</project>
diff --git a/tests/fixtures/demo/src/main/java/com/example/Main.java b/tests/fixtures/demo/src/main/java/com/example/Main.java
@@ -0,0 +1,11 @@
+package com.example;
+
+public class Main {
+	public static void main(String[] args) {
+		System.out.println(greet());
+	}
+
+	public static String greet() {
+		return "Hello from nvim-java";
+	}
+}
diff --git a/tests/fixtures/demo/src/test/java/com/example/MainTest.java b/tests/fixtures/demo/src/test/java/com/example/MainTest.java
@@ -0,0 +1,18 @@
+package com.example;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import org.junit.jupiter.api.Test;
+
+class MainTest {
+	@Test
+	void greetReturnsGreeting() {
+		assertEquals("Hello from nvim-java", Main.greet());
+	}
+
+	@Test
+	void greetIsNotEmpty() {
+		assertTrue(Main.greet().length() > 0);
+	}
+}
diff --git a/tests/specs/capabilities_spec.lua b/tests/specs/capabilities_spec.lua