MAINT: remove use of ld_classic on macOS#28713
Conversation
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
Thanks @adamjstewart. Can you please add a release note for this under ls doc/release/upcoming_changes/? It should be a new file named 28713.change.rst with a snippet (1-2 sentences) describing this removal.
I think this issue only matters for people who use rpath, which is mostly Spack.
Also Conda and Nix, but those should not be affected AFAIK because they didn't have an issue duplicate RPATHs.
|
Done, wasn't sure about formatting. |
|
Note that in the intel_sde_avx512 tests, the curl/tar command fails but the pipeline continues. If you set the shell to bash instead of sh, GitHub Actions will fail at first error instead of continuing. |
|
Nice, I've been seeing warnings related to this in my builds onc I upgraded my MacOS install but had no idea where they were coming from. The Linux SIMD test failure is unrelated I think. @adamjstewart feel free to send in a PR to fix broken CI but don't feel like it's your responsibility - someone will fix it eventually. |
3 participants
Fixes spack/spack#49983
Partially reverts #24967
On macOS, if one package uses ld (classic), all packages that link to it must also use ld (classic), otherwise you encounter issues with duplicate rpaths. Spack's OpenBLAS package no longer uses ld (classic), therefore numpy must also use ld (new) in order to build.
I think this issue only matters for people who use rpath, which is mostly Spack.
@rgommers